proof(ir): guarded-function halting twin (lane 2.2) - #2299
Merged
Conversation
execIRStmts_guardedFunction_halting mirrors #2296 for bodies ending in a modeled halt — both exit classes are now covered at the full-function level, matching the guardedUnit pair.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a2485818-dc7c-44be-a6cd-b01d09cbb773) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors #2296 for modeled-halt endings:
execIRStmts_guardedFunction_halting. Both exit classes of the guarded function composition are now covered, matching theguardedUnitpair (#2294).Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Additive Lean proof only; no compiler runtime, semantics, or axiom changes beyond registering one new public theorem.
Overview
Adds
execIRStmts_guardedFunction_halting, the halting counterpart toexecIRStmts_guardedFunction_fallthrough, for guarded function bodies that end in a modeled halt (return/stop/revert). The statement matches the fall-through theorem (param loads, lock revert vs acquire + release on success) but usesys ++ [h]andModeledHalt h, and the proof reuses param-load reduction plusexecIRStmts_guardedUnit_halting.The new theorem is listed in
PrintAxioms.leanso the axiom inventory stays complete. Together with the existing fall-through andguardedUnitpair, both exit shapes of the guarded-function IR composition are now covered at this layer.Reviewed by Cursor Bugbot for commit 6a7aae5. Bugbot is set up for automated code reviews on this repo. Configure here.