proof(ir): attachNonReentrantGuard halting twin (lane 2.2 pair complete) - #2300
Merged
Conversation
…2.2) attachNonReentrantGuard_exec_halting completes the pair: both exit classes of the transformation-level correctness statement now exist, symmetric with the guardedUnit and guardedFunction pairs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_41e8c310-0e6c-4998-81e3-85d093b6bd69) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the symmetric pair for #2297:
attachNonReentrantGuard_exec_haltingcovers modeled-halt bodies at the transformation level. Every statement in the guarded chain — unit, function, transformation — now exists in both exit classes.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Proof-only addition in IR generation simulation; no runtime or compiler behavior changes.
Overview
Adds
attachNonReentrantGuard_exec_halting, the halting counterpart toattachNonReentrantGuard_exec. It states that afterattachNonReentrantGuard, executing the guarded IR body matches the guarded semantics when the compiled body isgenParamLoadsplus a splice-sim fragment ending in a modeled halt (return/stop/revert), not a fall-through body.The proof reuses
attachNonReentrantGuard_some_shapeto relateguardedFn.bodyto the guarded prologue plus lock-release-wrapped(ys ++ [h]), then delegates toexecIRStmts_guardedFunction_halting.PrintAxioms.leanlists the new theorem so the axiom inventory stays complete.Reviewed by Cursor Bugbot for commit eb00e8a. Bugbot is set up for automated code reviews on this repo. Configure here.