You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reproduced it on main before looking at the change. The blank button only shows up when the app is in the light theme and the OS or browser prefers dark. The ghost variant leaves dark:hover:bg-accent/50 on the button. Tailwind v4 resolves dark: from prefers-color-scheme, not from our .dark class, so on hover the background turns translucent white under white text.
With your branch, hovering gives #2b7fff with white text in all three cases: OS prefers dark, OS prefers light, and the dark theme. Your new test fails on main and passes here, so it catches the regression.
The mismatch between the media-based dark: variant and the class-based theme probably affects other components too. I will track that separately, so it does not need to block this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Run Sel button becoming blank when the mouse hovers over it.
Type of Change
Related Issue
Closes #829
Changes Made
Testing
Test Environment
Checklist
Additional Notes
Added a regression test for the Run Sel button hover styling. Targeted QueryEditor tests pass locally (105/105).