-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Convert speedtest.js, speedtest_worker.js to ES6 with JSDoc comments #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
As far as I can see this would drop Internet Explorer support, right? |
|
Yes, it would break IE11 support. I'm also not familiar with the newer revisions of JavaScript so it would make it difficult for me to maintain. I appreciate your work but I can't merge this one yet |
|
Perfectly understood. |
6fba89e to
34c3991
Compare
|
Microsoft has pulled the plug on IE. This should no longer be an obstacle. |
|
@adolfintel Any interest in merging this (after conflicts are resolved)? |
|
@SCG82 I would be interested but I really need someone to maintain this project because I'm working full time and I don't have time to deal with something so large at the moment. |
Quentame
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@copilot try to analyse and rebase |
No description provided.