Add weekly nightly rustfmt job#97
Merged
benthecarman merged 3 commits intolightningdevkit:mainfrom Jan 16, 2026
Merged
Conversation
In LDK Node we found a `rustfmt.toml` that enables a few nice `nightly` features (such as automatic import grouping) while being backwards compatible with `rustfmt` stable. That means that in day-to-day we can continue to just do `cargo fmt`, but then have a simple weekly `rustfmt` job that cleans up the codebase a bit more.
.. mostly to show the changes.
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LDK Node's lightningdevkit/ldk-node#669 we added support for some
cargo +nightly fmtfeatures that are enforced by a weekly-run CI job that will create a new PR if any changes are necessary.Here we propose to follow the same model for LDK Server, as (IMO) there are some nice features (such as automatic import grouping) available in
rustfmtnightly.If we decide to do this, we might need to make some adjustments in Github repo preferences after this lands to actually allow the bot to open PRs. At least that was necessary in LDK Node IIRC.