Add a trivial helper to LSPS5's WebhookNotification
#4295
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LSPS5ServiceEvent::SendWebhookNotification`'s docs say to send the `WebhookNotification` as the HTTP request body "as JSON", which is great, but it leaves the dev to figure out how to do that. Its nice to have a helper to do that, which is trivial so we provide it here.
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Jan 1, 2026
| Self { method: WebhookNotificationMethod::LSPS5OnionMessageIncoming } | ||
| } | ||
|
|
||
| /// Encode's this notification into JSON which can be sent as the body of an HTTP request to |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Encode's this notification into JSON which can be sent as the body of an HTTP request to | |
| /// Encodes this notification into JSON which can be sent as the body of an HTTP request to |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4295 +/- ##
==========================================
- Coverage 89.38% 86.54% -2.84%
==========================================
Files 180 158 -22
Lines 139834 101824 -38010
Branches 139834 101824 -38010
==========================================
- Hits 124985 88128 -36857
+ Misses 12262 11278 -984
+ Partials 2587 2418 -169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSPS5ServiceEvent::SendWebhookNotification's docs say to send theWebhookNotificationas the HTTP request body "as JSON", which is great, but it leaves the dev to figure out how to do that. Its nice to have a helper to do that, which is trivial so we provide it here.