Skip to content

Add new failure reason#245

Merged
shreyav merged 1 commit intomainfrom
03-02-add_new_failure_reason
Mar 3, 2026
Merged

Add new failure reason#245
shreyav merged 1 commit intomainfrom
03-02-add_new_failure_reason

Conversation

@shreyav
Copy link
Contributor

@shreyav shreyav commented Mar 3, 2026

No description provided.

Copy link
Contributor Author

shreyav commented Mar 3, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shreyav shreyav marked this pull request as ready for review March 3, 2026 01:02
@shreyav shreyav force-pushed the 03-02-add_new_failure_reason branch from 54362ff to a9184b9 Compare March 3, 2026 01:03
@greptile-apps
Copy link

greptile-apps bot commented Mar 3, 2026

Greptile Summary

This PR adds MANUAL_REFUND as a new enum value to the OutgoingTransactionFailureReason schema across all three OpenAPI spec files (openapi/components/schemas/transactions/OutgoingTransactionFailureReason.yaml, openapi.yaml, and mintlify/openapi.yaml). The change provides a new failure classification for outgoing transactions that were manually refunded, giving API consumers more context on why a transaction entered a failed state.

  • Adding a new enum value is a backward-compatible change per the API versioning guidelines
  • All three spec files are updated consistently with identical content
  • The commit message contains no sensitive business information

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, backward-compatible enum addition with no logic changes.
  • The change adds a single new enum value to an existing string enum in all three relevant spec files. All files are consistent with each other, adding a new enum value is explicitly listed as a backward-compatible API change, and there are no code logic changes involved.
  • No files require special attention.

Important Files Changed

Filename Overview
openapi/components/schemas/transactions/OutgoingTransactionFailureReason.yaml Adds MANUAL_REFUND as a new enum value to OutgoingTransactionFailureReason; change is backward-compatible and is the canonical source file.
openapi.yaml Compiled OpenAPI spec updated consistently with MANUAL_REFUND enum addition; matches the canonical YAML source.
mintlify/openapi.yaml Mintlify documentation copy of the OpenAPI spec updated consistently with MANUAL_REFUND enum addition.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    TX[Outgoing Transaction] --> FAIL{Failed?}
    FAIL -- No --> OK[Transaction Active/Completed\nfailure_reason omitted]
    FAIL -- Yes --> REASON[OutgoingTransactionFailureReason]
    REASON --> QE[QUOTE_EXPIRED]
    REASON --> QEF[QUOTE_EXECUTION_FAILED]
    REASON --> LP[LIGHTNING_PAYMENT_FAILED]
    REASON --> FAM[FUNDING_AMOUNT_MISMATCH]
    REASON --> CPF[COUNTERPARTY_POST_TX_FAILED]
    REASON --> TO[TIMEOUT]
    REASON --> MR[MANUAL_REFUND 🆕]

    style MR fill:#d4edda,stroke:#28a745,color:#155724
Loading

Last reviewed commit: a9184b9

@shreyav shreyav merged commit 4a4c2f3 into main Mar 3, 2026
7 checks passed
@shreyav shreyav deleted the 03-02-add_new_failure_reason branch March 3, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants