allow umaaasVariableFeeRate to be 0

[shreyav]

No description provided.

[shreyav]

• allow umaaasVariableFeeRate to be 0 #246 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Greptile Summary

This PR relaxes the validation constraint on umaaasVariableFeeRate in both IncomingRateDetails and OutgoingRateDetails OpenAPI schemas, changing exclusiveMinimum: 0 to minimum: 0 to allow the field to be exactly 0 (representing a zero variable fee rate). The change is applied consistently across all 4 files (the two source schema YAMLs and their two compiled counterparts).

• IncomingRateDetails.yaml and OutgoingRateDetails.yaml: source schemas updated
• openapi.yaml and mintlify/openapi.yaml: compiled/flattened specs kept in sync
• All other fields (umaaasMultiplier, counterpartyMultiplier) retain exclusiveMinimum: 0 where a zero value would be semantically invalid (a multiplier of 0 would mean no conversion), which is correct and consistent
• The example: 0.003 value remains valid under the new constraint

Confidence Score: 5/5

• This PR is safe to merge — it is a minimal, targeted schema relaxation with no logic changes.
• The change is a single-line, semantically correct constraint update in 4 files (2 source + 2 derived). The intent is clear, the change is consistent across all copies, and relaxing exclusiveMinimum: 0 to minimum: 0 is a backwards-compatible schema change (existing valid values remain valid; only the previously-rejected value 0 is newly permitted).
• No files require special attention.

Important Files Changed

Filename	Overview
openapi/components/schemas/transactions/IncomingRateDetails.yaml	Changed exclusiveMinimum: 0 to minimum: 0 on umaaasVariableFeeRate, correctly allowing a zero fee rate for incoming transactions.
openapi/components/schemas/transactions/OutgoingRateDetails.yaml	Changed exclusiveMinimum: 0 to minimum: 0 on umaaasVariableFeeRate, correctly allowing a zero fee rate for outgoing transactions.
openapi.yaml	Compiled/flattened OpenAPI spec updated to reflect the same minimum: 0 changes as the source schema files.
mintlify/openapi.yaml	Mintlify documentation copy of the OpenAPI spec updated to reflect the same minimum: 0 changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[umaaasVariableFeeRate value] --> B{Validation}
    B -- "value < 0" --> C[❌ Rejected\nbelow minimum]
    B -- "value = 0" --> D["✅ Accepted\n(NEW: was previously rejected)"]
    B -- "value > 0" --> E[✅ Accepted\npositive fee rate]

    style D fill:#d4edda,stroke:#28a745
    style C fill:#f8d7da,stroke:#dc3545
    style E fill:#d4edda,stroke:#28a745

Loading

_{Last reviewed commit: 32a1e4a}