Skip to content

chore(deps): add prost and tonic dependabot groups #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cratelyn wants to merge 1 commit into from
Closed

chore(deps): add prost and tonic dependabot groups #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ updates:
directory: /
schedule:
interval: daily
groups:
prost:
patterns:
- "prost*"
tonic:
patterns:
- "tonic*"
Comment on lines +7 to +13
Copy link
Copy Markdown
Member

@olix0r olix0r Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these dependencies have to be updated together?

Copy link
Copy Markdown
Member Author

@cratelyn cratelyn Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. i noticed these are not maintained as part of the same organization (see repository url's below), and we don't update these together in the proxy at the moment.

i think you're right though. prost generates code based on the tonic interfaces, so.. we should probably do the same thing as the control plane.

Copy link
Copy Markdown
Member Author

@cratelyn cratelyn Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkerd/linkerd2-proxy#3821 consolidates these groups together. i can do the same here, i'll mark this as a draft in the meantime.


- package-ecosystem: gomod
directory: /
Expand Down