ACLP: Cleanup entity related response fields from alert definition#690
Merged
Conversation
Add entities envelope in AlertDefinition. Add list entities GET API method. Add tests.
…to feat/aclp-list-entities
Remove entity_ids and has_more_resources response fields
…to cleanup/entity-related-fields
yec-akamai
reviewed
Apr 28, 2026
| parent_id_name = "service_type" | ||
| id_attribute = "id" | ||
|
|
||
| properties = { |
Contributor
There was a problem hiding this comment.
I find channel_ids is missing in the properties in previous implemenatation. Can you add it please? It's not in the response struct, but should be updatable just like entity_ids.
Contributor
Author
There was a problem hiding this comment.
Thanks Ye. I have updated the properties.
shkaruna
requested review from
ckulinsk and
yec-akamai
and removed request for
a team
yec-akamai
added
the
community-contribution
yec-akamai
approved these changes
May 5, 2026
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
LGTM. Tests passed locally
zliang-akamai
approved these changes
May 5, 2026
yec-akamai
added
the
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Cleanup entity related response fields from alert definition.
Removed entity_ids and has_more_resources response fields of ACLP alerting APIs.
Updated test cases.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
Not applicable
How do I run the relevant unit/integration tests?
Prerequisites:
Clone the repository
Prepare environment (zsh / macOS)
Create and activate venv:
python3 -m venv .venv
source .venv/bin/activate
install deps
python -m pip install --upgrade pip
Install runtime dependencies:
pip3 install requests polling deprecated
Install dev/test extras
pip3 install -e '.[dev,test]'
test deps
pip3 install pytest mock httpretty pytest-rerunfailures
Unit test:
Run all unit tests:
python -m pytest test/unit -q
Run Monitor alert channels unit tests:
python -m pytest test/unit/groups/monitor_api_test.py -q -s
....
4 passed in 0.13s
Integration test:
#if you have PAT token with write access only to Monitor and read for rest of the services for integration
export SKIP_E2E_FIREWALL=1 # optional: skip firewall to use fixture
export LINODE_TOKEN="YOUR_REAL_TOKEN" # required for integration
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
.
1 passed in 12.57s