Skip to content

TPT-4462: Add test for RDMA Linode instance creation - #733

Open
mawilk90 wants to merge 1 commit into
linode:proj/rdma-interfacesfrom
mawilk90:feature/TPT-4462-add-int-test-for-rdma-linode-instance
Open

TPT-4462: Add test for RDMA Linode instance creation#733
mawilk90 wants to merge 1 commit into
linode:proj/rdma-interfacesfrom
mawilk90:feature/TPT-4462-add-int-test-for-rdma-linode-instance

Conversation

@mawilk90

Copy link
Copy Markdown
Contributor

📝 Description

Additional test case for RDMA linode instance creation with linodepy

Note:
test_linode_interfaces_with_rdma_vpc_type is marked as skipped because it requires manual infra changes

✔️ How to Test

make test-int TEST_ARGS="-k test_linode_interfaces_with_rdma_vpc_type"

@mawilk90
mawilk90 requested review from a team as code owners August 19, 2026 15:11
@mawilk90
mawilk90 requested review from jriddle-linode, lgarber-akamai, psnoch-akamai and yec-akamai and a lite review from Copilot and removed request for a team and jriddle-linode August 19, 2026 15:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an (currently skipped) integration test intended to validate creation of Linode instances configured with RDMA VPC interfaces, plus supporting fixtures/helpers to create RDMA VPC resources in a consistent region.

Changes:

  • Add helpers and a new (skipped) integration test for creating a Linode with multiple RDMA VPC interfaces plus a regular VPC interface.
  • Extend integration fixtures to reuse a chosen VPC region across VPC and RDMA-VPC creation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
test/integration/models/linode/interfaces/test_interfaces.py Adds RDMA interface builders and a skipped test for RDMA Linode instance creation using Linode interfaces.
test/integration/conftest.py Introduces a shared VPC region variable to align region selection between VPC and RDMA VPC fixtures.
Suppressed comments (1)

test/integration/models/linode/interfaces/test_interfaces.py:520

  • firewall_id=-1 will be sent to the API as an invalid firewall ID. If the intent is “no firewall”, pass None (the key will still be included due to always_include).
            firewall_id=-1,

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/integration/models/linode/interfaces/test_interfaces.py
Comment thread test/integration/models/linode/interfaces/test_interfaces.py
Comment thread test/integration/models/linode/interfaces/test_interfaces.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants