TPT-4277: Merge main#949
Open
mgwoj wants to merge 18 commits intoproj/reserved-ipsfrom
Open
Conversation
* build(deps): bump golang.org/x/oauth2 from 0.35.0 to 0.36.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.35.0 to 0.36.0. - [Commits](golang/oauth2@v0.35.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com>
…elease notes workflow (#913) * Added PR title checking to lint and clean up release notes * Fixed CoPilot suggestions * Exclude dependabot PRs from PR title validation * Address CoPilot suggestions * Add exemptions for hotfixes and external contributions * Switch to using amannn/action-semantic-pull-request@v6 for title validation * Add exemption for dependencies label and remove dependabot author check
* Redact sensitive data from logging * Address copilot suggestions * TPT-4014 Address comments suggestions
…reateOptions (#921) * Update FirewallID to use single pointer in LinodeInterfaceCreateOptions * Fix test
) * build(deps): bump slackapi/slack-github-action from 2.1.1 to 3.0.1 Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 2.1.1 to 3.0.1. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v2.1.1...v3.0.1) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Apply suggestions from code review Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* TPT-4318: Add @linode/dx-sdets to CODEOWNERS * Correct CODEOWNERS
* Added DiskEncryption field for LKE Node Pool creation * Address CoPilot suggestions * Removed more LA notices * Update disk_encryption field to be a pointer
* build(deps): bump golang.org/x/net from 0.51.0 to 0.52.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.51.0 to 0.52.0. - [Commits](golang/net@v0.51.0...v0.52.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.52.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * go mod tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lena Garber <lgarber@akamai.com>
…field to firewall (#901) * Fix firewall device for linode interfaces#829 * Fix unit test * Update the unit test * feat: add entities field to Firewall struct and define FirewallEntity type * Fix unit test * Integration test update * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update FirewallDeviceEntity and tests * Reuse FirewallDeviceEntity * fmt * Fix test --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Michal Wojcik <32574975+mgwoj@users.noreply.github.com>
Add entity envelope in AlertDefinition GET, POST and PUT API responses. Add new method to list entities. Update tests.
* build(deps): bump golang.org/x/net from 0.52.0 to 0.53.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.52.0 to 0.53.0. - [Commits](golang/net@v0.52.0...v0.53.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.53.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <ezilber@akamai.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 8 to 9. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v8...v9) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '9' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nstance definitions (#935)
* Add obj global quota and throughput and concurrency quotas * Refresh list obj quota fixture
mgwoj
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team
ezilber-akamai
approved these changes
May 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Merge from main that pulls in newer API surface updates and repo maintenance changes across the Go client, tests, fixtures, and GitHub workflows.
Changes:
- Adds/updates client models for object storage quotas, monitor alert definitions/channels, firewalls, interfaces, and LKE disk encryption.
- Refreshes unit/integration tests and recorded fixtures to match newer API responses and request shapes.
- Syncs repo maintenance files such as module dependencies, workflows, CODEOWNERS, and client log redaction.
Reviewed changes
Copilot reviewed 41 out of 66 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| volumes.go | Removes outdated encryption availability note. |
| test/unit/monitor_alert_definitions_test.go | Expands monitor alert definition unit coverage. |
| test/unit/monitor_alert_channels_test.go | Adds unit coverage for alert channel listing. |
| test/unit/interface_test.go | Updates interface test to new firewall pointer shape. |
| test/unit/fixtures/firewall_create.json | Adds firewall entity data to unit fixture. |
| test/unit/firewalls_test.go | Verifies firewall timestamps and entities. |
| test/unit/firewall_devices_test.go | Adds parent-entity assertions for firewall devices. |
| test/integration/object_storage_quota_test.go | Relaxes quota assertions and checks new fields. |
| test/integration/object_storage_global_quota_test.go | Adds integration coverage for global quotas. |
| test/integration/monitor_alert_definitions_test.go | Adds assertions for new alert/channel fields and entity listing. |
| test/integration/lke_node_pools_test.go | Exercises LKE disk encryption behavior. |
| test/integration/instance_interfaces_test.go | Updates interface firewall pointer usage. |
| test/integration/fixtures/TestObjectStorageQuotas_List.yaml | Refreshes object storage quota list cassette. |
| test/integration/fixtures/TestObjectStorageQuotas_Get.yaml | Refreshes object storage quota get cassette. |
| test/integration/fixtures/TestObjectStorageGlobalQuotaUsage_Get.yaml | Adds global quota usage cassette. |
| test/integration/fixtures/TestObjectStorageGlobalQuotas_List.yaml | Adds global quota list cassette. |
| test/integration/fixtures/TestObjectStorageGlobalQuotas_Get.yaml | Adds global quota get cassette. |
| test/integration/fixtures/TestMonitorAlertDefinitions_List.yaml | Refreshes alert-definition list cassette. |
| test/integration/fixtures/TestMonitorAlertDefinitionEntities_List.yaml | Adds alert-definition entities cassette. |
| test/integration/fixtures/TestMonitorAlertDefinition.yaml | Refreshes alert-definition CRUD cassette. |
| test/integration/fixtures/TestMonitorAlertDefinition_CreateWithIdempotency.yaml | Refreshes idempotency cassette. |
| test/integration/fixtures/TestMonitorAlertChannels_List.yaml | Refreshes alert-channel list cassette. |
| test/integration/fixtures/TestLKENodePool_GetMissing.yaml | Refreshes missing-node-pool cassette headers. |
| test/integration/fixtures/TestLKENodePool_GetFound_k8s.yaml | Refreshes LKE node pool Kubernetes cassette. |
| test/integration/fixtures/TestListMonitorAlertChannels.yaml | Removes obsolete monitor alert channel cassette. |
| test/integration/fixtures/TestFirewall_Update.yaml | Refreshes firewall update cassette. |
| test/integration/fixtures/TestFirewall_Get.yaml | Refreshes firewall get cassette. |
| test/integration/fixtures/TestCreateMonitorAlertDefinitionWithIdempotency.yaml | Removes obsolete idempotency cassette. |
| test/integration/firewalls_test.go | Adds firewall entity assertions in integration tests. |
| test/integration/firewalls_devices_test.go | Adds device/entity assertions around firewall attachments. |
| test/go.sum | Updates test module dependency hashes. |
| test/go.mod | Bumps test module x/* dependencies. |
| object_storage_quota.go | Adds quota fields and global quota APIs/models. |
| monitor_alert_definitions.go | Adds scope/entities support and entity-list API. |
| monitor_alert_channels.go | Simplifies alert-channel model to current payload fields. |
| lke_node_pools.go | Adds LKE node pool disk encryption create support. |
| k8s/go.sum | Updates k8s module dependency hashes. |
| k8s/go.mod | Bumps k8s module x/* dependencies. |
| interfaces.go | Changes interface create firewall field shape. |
| instances.go | Syncs instance model/create/rebuild fields and comments. |
| instance_disks.go | Syncs disk model formatting/comments. |
| go.sum | Updates root module dependency hashes. |
| go.mod | Bumps root module x/* dependencies. |
| firewalls.go | Adds firewall entities and renames interface device field. |
| firewall_devices.go | Adds nested parent entity support. |
| CODEOWNERS | Adds SDET team ownership. |
| client.go | Adds request/response header redaction for debug logging. |
| client_test.go | Adds tests for header redaction and log sanitization. |
| account_settings.go | Removes outdated interface availability note. |
| .github/workflows/release-notify-slack.yml | Bumps Slack action version. |
| .github/workflows/nightly_smoke_tests.yml | Bumps Slack action version. |
| .github/workflows/integration_tests_pr.yml | Bumps github-script action version. |
| .github/workflows/clean-release-notes.yml | Adds workflow to strip ticket prefixes from releases. |
| .github/workflows/ci.yml | Adds PR title validation and bumps Slack action version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
28
| type AlertChannel struct { | ||
| Alerts AlertsInfo `json:"alerts"` | ||
| ChannelType AlertNotificationType `json:"channel_type"` | ||
| Content ChannelContent `json:"content"` | ||
| Details ChannelDetails `json:"details"` |
Comment on lines
+35
to
39
| Linodes []int `json:"linodes,omitempty"` | ||
| NodeBalancers []int `json:"nodebalancers,omitempty"` | ||
| LinodeInterfaces []int `json:"linode_interfaces,omitempty"` | ||
| } | ||
|
|
|
|
||
| type LinodeInterfaceCreateOptions struct { | ||
| FirewallID **int `json:"firewall_id,omitempty"` | ||
| FirewallID *int `json:"firewall_id,omitempty"` |
Comment on lines
+32
to
+40
| QuotaLimit int `json:"quota_limit"` | ||
| ResourceMetric string `json:"resource_metric"` | ||
| HasUsage bool `json:"has_usage"` | ||
| } | ||
|
|
||
| // ObjectStorageGlobalQuotaUsage is the usage data for a specific global/account-level Object Storage quota. | ||
| type ObjectStorageGlobalQuotaUsage struct { | ||
| QuotaLimit int `json:"quota_limit"` | ||
| Usage *int `json:"usage"` |
Comment on lines
+314
to
+321
| alerts, err := client.ListAllMonitorAlertDefinitions(context.Background(), nil) | ||
| assert.NoError(t, err) | ||
| assert.NotEmpty(t, alerts) | ||
|
|
||
| entities, err := client.ListMonitorAlertDefinitionEntities( | ||
| context.Background(), | ||
| testMonitorAlertDefinitionServiceType, | ||
| alerts[0].ID, |
Comment on lines
857
to
866
| func (c *Client) enableLogSanitization() *Client { | ||
| c.resty.OnRequestLog(func(r *resty.RequestLog) error { | ||
| // masking authorization header | ||
| r.Header.Set("Authorization", "Bearer *******************************") | ||
| redactLogHeaders(r.Header) | ||
| return nil | ||
| }) | ||
|
|
||
| c.resty.OnResponseLog(func(r *resty.ResponseLog) error { | ||
| redactLogHeaders(r.Header) | ||
| return nil | ||
| }) |
…alert fixes) (#948) * build(deps): bump gopkg.in/ini.v1 from 1.67.1 to 1.67.2 Bumps gopkg.in/ini.v1 from 1.67.1 to 1.67.2. --- updated-dependencies: - dependency-name: gopkg.in/ini.v1 dependency-version: 1.67.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * go mod tidy * Replace reflect.Ptr with reflect.Pointer * Ignore linter alert for `"text/html"` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> Co-authored-by: Erik Zilber <ezilber@akamai.com>
yec-akamai
approved these changes
May 5, 2026
zliang-akamai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.