TPT-3391: Added distinction between Object Storage Bucket Access POST/PUT endpoints#951
Open
ezilber-akamai wants to merge 1 commit intolinode:proj/linodego_v2from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR clarifies the distinction between the Object Storage Bucket Access POST vs PUT endpoints by introducing a dedicated “modify” API (POST) while updating the existing “update” API to use PUT, and adjusts unit/integration coverage + fixtures accordingly.
Changes:
- Added
ModifyObjectStorageBucketAccess+ObjectStorageBucketModifyAccessOptionsfor the POST/accessendpoint. - Switched
UpdateObjectStorageBucketAccessfrom POST to PUT and added adoPUTRequestNoResponseBodyhelper. - Updated unit/integration tests and recorded fixtures to reflect the POST (modify) vs PUT (update) split.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
object_storage_buckets.go |
Adds Modify (POST) access API/options and changes Update to PUT. |
request_helpers.go |
Adds doPUTRequestNoResponseBody helper used by the PUT update path. |
test/unit/object_storage_bucket_test.go |
Adds Modify-access unit test and updates Update-access to expect PUT. |
test/integration/object_storage_buckets_test.go |
Adds Modify-access integration test alongside Update-access test. |
test/integration/fixtures/TestObjectStorageBucket_Access_Modify.yaml |
New fixture capturing POST modify interaction sequence. |
test/integration/fixtures/TestObjectStorageBucket_Access_Update.yaml |
Updates fixture to reflect PUT update interaction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zliang-akamai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added
ModifyObjectStorageBucketAccessstruct and swapped it withUpdateObjectStorageBucketAccesssuch that Modify is for the POST endpoint and Update is for the PUT endpoint to avoid confusion.As of right now, both endpoints do the same exact thing but we want separate structs in case this changes in the future.
✔️ How to Test
make test-unitmake test-int