Skip to content

TPT-3391: Added distinction between Object Storage Bucket Access POST/PUT endpoints#951

Open
ezilber-akamai wants to merge 1 commit intolinode:proj/linodego_v2from
ezilber-akamai:TPT-3391-rename-obj-bucket-access-structs
Open

TPT-3391: Added distinction between Object Storage Bucket Access POST/PUT endpoints#951
ezilber-akamai wants to merge 1 commit intolinode:proj/linodego_v2from
ezilber-akamai:TPT-3391-rename-obj-bucket-access-structs

Conversation

@ezilber-akamai
Copy link
Copy Markdown
Contributor

@ezilber-akamai ezilber-akamai commented May 5, 2026

📝 Description

Added ModifyObjectStorageBucketAccess struct and swapped it with UpdateObjectStorageBucketAccess such that Modify is for the POST endpoint and Update is for the PUT endpoint to avoid confusion.

As of right now, both endpoints do the same exact thing but we want separate structs in case this changes in the future.

✔️ How to Test

make test-unit
make test-int

Copilot AI review requested due to automatic review settings May 5, 2026 20:29
@ezilber-akamai ezilber-akamai added the breaking-change for breaking changes in the changelog. label May 5, 2026
@ezilber-akamai ezilber-akamai requested review from a team as code owners May 5, 2026 20:29
@ezilber-akamai ezilber-akamai requested review from ckulinsk and mgwoj and removed request for a team May 5, 2026 20:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies the distinction between the Object Storage Bucket Access POST vs PUT endpoints by introducing a dedicated “modify” API (POST) while updating the existing “update” API to use PUT, and adjusts unit/integration coverage + fixtures accordingly.

Changes:

  • Added ModifyObjectStorageBucketAccess + ObjectStorageBucketModifyAccessOptions for the POST /access endpoint.
  • Switched UpdateObjectStorageBucketAccess from POST to PUT and added a doPUTRequestNoResponseBody helper.
  • Updated unit/integration tests and recorded fixtures to reflect the POST (modify) vs PUT (update) split.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
object_storage_buckets.go Adds Modify (POST) access API/options and changes Update to PUT.
request_helpers.go Adds doPUTRequestNoResponseBody helper used by the PUT update path.
test/unit/object_storage_bucket_test.go Adds Modify-access unit test and updates Update-access to expect PUT.
test/integration/object_storage_buckets_test.go Adds Modify-access integration test alongside Update-access test.
test/integration/fixtures/TestObjectStorageBucket_Access_Modify.yaml New fixture capturing POST modify interaction sequence.
test/integration/fixtures/TestObjectStorageBucket_Access_Update.yaml Updates fixture to reflect PUT update interaction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread request_helpers.go
Comment thread object_storage_buckets.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change for breaking changes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants