Skip to content

fix: Add right-click menu to fold messages#1529

Closed
pengfeixx wants to merge 1 commit intolinuxdeepin:masterfrom
pengfeixx:fix-353605
Closed

fix: Add right-click menu to fold messages#1529
pengfeixx wants to merge 1 commit intolinuxdeepin:masterfrom
pengfeixx:fix-353605

Conversation

@pengfeixx
Copy link
Contributor

@pengfeixx pengfeixx commented Mar 24, 2026

Add right-click menu to fold messages

Log: Add right-click menu to fold messages
pms: BUG-353605

Summary by Sourcery

New Features:

  • Enable right-click handling on notification items to open the message settings or folding menu.

Add right-click menu to fold messages

Log: Add right-click menu to fold messages
pms: BUG-353605
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a right-click context interaction to the notification fold button so users can open the settings/folding menu via right-click, without affecting existing left-click and keyboard behavior.

Sequence diagram for right-click folding context menu on notification

sequenceDiagram
    actor User
    participant NotificationFoldButton as NotificationFoldButton
    participant TapHandlerRightClick as TapHandler
    participant RootNotifyItem as root

    User->>NotificationFoldButton: Right-click (Qt.RightButton)
    NotificationFoldButton->>TapHandlerRightClick: Pointer event
    TapHandlerRightClick->>TapHandlerRightClick: onPressedChanged(pressed == true)
    TapHandlerRightClick->>RootNotifyItem: setting(pos)
    RootNotifyItem-->>User: Show folding/settings menu

    User->>NotificationFoldButton: Left-click / Enter / Return
    NotificationFoldButton->>RootNotifyItem: expand()
    RootNotifyItem-->>User: Expand notification
Loading

File-Level Changes

Change Details Files
Add right-click (context) TapHandler to trigger the notification settings/fold menu when the fold control is right-clicked.
  • Introduce a TapHandler configured to accept only the right mouse button on the notification action area.
  • On right-button press, capture the click position from the handler and call root.setting with that position.
  • Preserve existing left-click (expand) and keyboard (Enter/Return) behavior without modification.
panels/notification/center/OverlapNotify.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pengfeixx pengfeixx closed this Mar 24, 2026
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether root.setting(pos) expects local or scene/global coordinates; if it needs screen-relative positioning you may want to map point.position accordingly before invoking the menu.
  • Using onPressedChanged with a pressed check will fire on both press and release transitions—if you only need the initial right-click, switching to a dedicated press handler (e.g., onPressed) would make the intent clearer and avoid double invocation risks.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether `root.setting(pos)` expects local or scene/global coordinates; if it needs screen-relative positioning you may want to map `point.position` accordingly before invoking the menu.
- Using `onPressedChanged` with a `pressed` check will fire on both press and release transitions—if you only need the initial right-click, switching to a dedicated press handler (e.g., `onPressed`) would make the intent clearer and avoid double invocation risks.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants