Move mount/unmount interaction and handling to Cinnamon by mtwebster · Pull Request #13145 · linuxmint/cinnamon

mtwebster · 2025-10-16T18:57:18Z

Implement mount/unmount/autorun user interaction in Cinnamon.

Certain aspects of GtkMountOperation are broken under Wayland in
Gtk3 and won't be fixed. Fortunately it can also use a dbus
interface (org.gtk.MountOperationHandler) if a provider exists.

This allows us to:

provide the 'device is in use' popup and showing which
application is using it, when trying to eject a device.
provide the password/question dialog when mounting devices that
require interaction before mounting.
eliminate a lot of code and translations from placesManager,
and make the behavior identical when interacting with a device
whether from a file manager or Cinnamon's drives applet.
Translations are provided by Gtk, Gvfs instead (as when
ejecting a device from a file manager).
Adds testMountDialogs.js for theme/dialog testing (activatable
via looking-glass).
Also replace mount-detection handling in cinnamon-settings-daemon.
It was originally part of Cinnamon but mostly removed early on
when Cinnamon was forked, and we've relied on csd-automount.

With the implementation of CinnamonMountOperation for handling
unmount operations, we can bring in the autorun dialog as well.

csd-automount is still used in fallback mode and managed by
cinnamon-launcher in those situations (nm-applet, polkit agents
are already handled here also).
csd-automount: Disable autostart. cinnamon-settings-daemon#445
disables autostarting csd-automount at session startup.
Adds testAutorunDialog.js for theme/dialog testing (activatable
via looking-glass).

Moving its responsibilities to cinnamon, this will only be needed during 'fallback' mode for now. ref: linuxmint/cinnamon#13145.

github-actions · 2026-04-09T13:45:59Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 3 potential issue(s):

⚠️ gio_volume_monitor

js/ui/automountManager.js:31

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

js/ui/autorunManager.js:169

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

⚠️ gtk_forbidden

js/ui/cinnamonMountOperation.js:23

<interface name="org.Gtk.MountOperationHandler"> \

Most Gtk APIs cannot be used in the Cinnamon runtime.
Use St (Shell Toolkit) equivalents instead.
Allowed Gtk APIs: IconTheme, DirectionType, TextDirection, PositionType,
accelerator_parse, accelerator_get_label, accelerator_name,
Settings, Widget.get_default_direction.

Automated pattern check.

github-actions · 2026-04-09T14:29:44Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 3 potential issue(s):

⚠️ gio_volume_monitor

js/ui/automountManager.js:31

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

js/ui/autorunManager.js:169

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

⚠️ gtk_forbidden

js/ui/cinnamonMountOperation.js:23

<interface name="org.Gtk.MountOperationHandler"> \

Most Gtk APIs cannot be used in the Cinnamon runtime.
Use St (Shell Toolkit) equivalents instead.
Allowed Gtk APIs: IconTheme, DirectionType, TextDirection, PositionType,
accelerator_parse, accelerator_get_label, accelerator_name,
Settings, Widget.get_default_direction.

Automated pattern check.

github-actions · 2026-04-09T16:55:32Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 3 potential issue(s):

⚠️ gio_volume_monitor

js/ui/automountManager.js:31

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

js/ui/autorunManager.js:169

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

⚠️ gtk_forbidden

js/ui/cinnamonMountOperation.js:23

<interface name="org.Gtk.MountOperationHandler"> \

Most Gtk APIs cannot be used in the Cinnamon runtime.
Use St (Shell Toolkit) equivalents instead.
Allowed Gtk APIs: IconTheme, DirectionType, TextDirection, PositionType,
accelerator_parse, accelerator_get_label, accelerator_name,
Settings, Widget.get_default_direction.

Automated pattern check.

fires from logind/ck.

github-actions · 2026-04-09T19:06:14Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 3 potential issue(s):

⚠️ gio_volume_monitor

js/ui/automountManager.js:34

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

js/ui/autorunManager.js:169

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

⚠️ gtk_forbidden

js/ui/cinnamonMountOperation.js:23

<interface name="org.Gtk.MountOperationHandler"> \

Most Gtk APIs cannot be used in the Cinnamon runtime.
Use St (Shell Toolkit) equivalents instead.
Allowed Gtk APIs: IconTheme, DirectionType, TextDirection, PositionType,
accelerator_parse, accelerator_get_label, accelerator_name,
Settings, Widget.get_default_direction.

Automated pattern check.

github-actions · 2026-04-09T19:33:00Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 3 potential issue(s):

⚠️ gio_volume_monitor

js/ui/automountManager.js:34

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

js/ui/autorunManager.js:169

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

⚠️ gtk_forbidden

js/ui/cinnamonMountOperation.js:23

<interface name="org.Gtk.MountOperationHandler"> \

Most Gtk APIs cannot be used in the Cinnamon runtime.
Use St (Shell Toolkit) equivalents instead.
Allowed Gtk APIs: IconTheme, DirectionType, TextDirection, PositionType,
accelerator_parse, accelerator_get_label, accelerator_name,
Settings, Widget.get_default_direction.

Automated pattern check.

Certain aspects of GtkMountOperation are broken under Wayland in Gtk3 and won't be fixed. Fortunately it can also use a dbus interface (org.gtk.MountOperationHandler) if a provider exists. This allows us to: - provide the 'device is in use' popup and showing which application is using it, when trying to eject a device. - provide the password/question dialog when mounting devices that require interaction before mounting. - eliminate a lot of code and translations from placesManager, and make the behavior identical when interacting with a device whether from a file manager or Cinnamon's drives applet. Translations are provided by Gtk, Gvfs instead (as when ejecting a device from a file manager). - Adds testMountDialogs.js for theme/dialog testing (activatable via looking-glass). Also replace mount-detection handling in cinnamon-settings-daemon. It was originally part of Cinnamon but mostly removed early on when Cinnamon was forked, and we've relied on csd-automount. With the implementation of CinnamonMountOperation for handling unmount operations, we can bring in the autorun dialog as well. - csd-automount is still used in fallback mode and managed by cinnamon-launcher in those situations (nm-applet, polkit agents are already handled here also). - linuxmint/cinnamon-settings-daemon#445 disables autostarting csd-automount at session startup. - Adds testAutorunDialog.js for theme/dialog testing (activatable via looking-glass).

github-actions · 2026-04-09T19:45:37Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 3 potential issue(s):

⚠️ gio_volume_monitor

js/ui/automountManager.js:34

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

js/ui/autorunManager.js:171

this._volumeMonitor = Gio.VolumeMonitor.get();

Use Main.placesManager instead of Gio.VolumeMonitor directly.
PlacesManager provides a unified API for bookmarks, mounts, volumes,
and drives with debounced updates and safe eject/unmount handling.

⚠️ gtk_forbidden

js/ui/cinnamonMountOperation.js:23

<interface name="org.Gtk.MountOperationHandler"> \

Most Gtk APIs cannot be used in the Cinnamon runtime.
Use St (Shell Toolkit) equivalents instead.
Allowed Gtk APIs: IconTheme, DirectionType, TextDirection, PositionType,
accelerator_parse, accelerator_get_label, accelerator_name,
Settings, Widget.get_default_direction.

Automated pattern check.

Moving its responsibilities to cinnamon, this will only be needed during 'fallback' mode for now. ref: linuxmint/cinnamon#13145.

mtwebster marked this pull request as draft October 16, 2025 18:57

mtwebster mentioned this pull request Nov 21, 2025

[WIP] Add a dialog to unmount devices when using Wayland linuxmint/nemo#3558

Open

mtwebster changed the title ~~Move mount/unmount interaction and handling to Cinnamon~~ [wip] Move mount/unmount interaction and handling to Cinnamon Nov 24, 2025

clefebvre changed the title ~~[wip] Move mount/unmount interaction and handling to Cinnamon~~ [WIP] Move mount/unmount interaction and handling to Cinnamon Nov 25, 2025

mtwebster force-pushed the mount-stuff branch from fbca147 to 3cdf467 Compare March 11, 2026 01:00

This comment was marked as outdated.

Sign in to view

mtwebster added a commit to mtwebster/cinnamon-settings-daemon that referenced this pull request Mar 11, 2026

csd-automount: Disable autostart.

61a9b01

Moving its responsibilities to cinnamon, this will only be needed during 'fallback' mode for now. ref: linuxmint/cinnamon#13145.

mtwebster mentioned this pull request Mar 11, 2026

csd-automount: Disable autostart. linuxmint/cinnamon-settings-daemon#445

Merged

mtwebster changed the title ~~[WIP] Move mount/unmount interaction and handling to Cinnamon~~ Move mount/unmount interaction and handling to Cinnamon Mar 12, 2026

mtwebster force-pushed the mount-stuff branch from 3cdf467 to 8cd67e3 Compare March 12, 2026 18:03

mtwebster marked this pull request as ready for review March 12, 2026 18:06

mtwebster force-pushed the mount-stuff branch 2 times, most recently from e120319 to eb4258a Compare March 14, 2026 00:47

This comment was marked as outdated.

Sign in to view

linuxmint deleted a comment from github-actions bot Mar 14, 2026

mtwebster force-pushed the mount-stuff branch from eb4258a to b90c6ce Compare March 16, 2026 19:46

This comment was marked as outdated.

Sign in to view

mtwebster force-pushed the mount-stuff branch from b90c6ce to 5a730c8 Compare April 9, 2026 13:45

mtwebster force-pushed the mount-stuff branch from 5a730c8 to 0461127 Compare April 9, 2026 14:29

mtwebster force-pushed the mount-stuff branch from 0461127 to cec228b Compare April 9, 2026 16:55

loginManager: add sessionIsActive property updated when ActiveChanged

8875ccf

fires from logind/ck.

mtwebster force-pushed the mount-stuff branch from cec228b to 1d836fd Compare April 9, 2026 19:05

mtwebster force-pushed the mount-stuff branch from 1d836fd to 7a7da93 Compare April 9, 2026 19:32

mtwebster force-pushed the mount-stuff branch from 7a7da93 to d9e1ba4 Compare April 9, 2026 19:45

mtwebster added a commit to linuxmint/cinnamon-settings-daemon that referenced this pull request Apr 9, 2026

csd-automount: Disable autostart. (#445)

6742483

Moving its responsibilities to cinnamon, this will only be needed during 'fallback' mode for now. ref: linuxmint/cinnamon#13145.

mtwebster merged commit 9bdd28c into master Apr 9, 2026
3 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move mount/unmount interaction and handling to Cinnamon#13145

Move mount/unmount interaction and handling to Cinnamon#13145
mtwebster merged 2 commits intomasterfrom
mount-stuff

mtwebster commented Oct 16, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mtwebster commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Apr 9, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ gio_volume_monitor

⚠️ gtk_forbidden

Uh oh!

github-actions bot commented Apr 9, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ gio_volume_monitor

⚠️ gtk_forbidden

Uh oh!

github-actions bot commented Apr 9, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ gio_volume_monitor

⚠️ gtk_forbidden

Uh oh!

github-actions bot commented Apr 9, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ gio_volume_monitor

⚠️ gtk_forbidden

Uh oh!

github-actions bot commented Apr 9, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ gio_volume_monitor

⚠️ gtk_forbidden

Uh oh!

github-actions bot commented Apr 9, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ gio_volume_monitor

⚠️ gtk_forbidden

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mtwebster commented Oct 16, 2025 •

edited

Loading