Skip to content

network@cinnamon.org: don't show the offline icon when online through an unmanaged device #13924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fantu wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −2
Open

network@cinnamon.org: don't show the offline icon when online through an unmanaged device #13924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
207bcc6
network@cinnamon.org: don't show the offline icon when online through…
Fantu Aug 8, 2026
a89a5cb
network@cinnamon.org: tell the unmanaged case apart in the tooltip
Fantu Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions files/usr/share/cinnamon/applets/network@cinnamon.org/applet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2403,8 +2403,17 @@ CinnamonNetworkApplet.prototype = {
let mc = this._mainConnection;

if (!mc) {
this._setIcon('xsi-network-offline');
this.set_applet_tooltip(_("No connection"));
if (this._client.state == NM.State.CONNECTED_GLOBAL) {
// We are online through a device NetworkManager does not
// manage (for instance one configured in
// /etc/network/interfaces): there is no active connection
// to describe, but we are not offline either.
this._setIcon('xsi-network-wired');
this.set_applet_tooltip(_("Connected through an unmanaged device"));
} else {
this._setIcon('xsi-network-offline');
this.set_applet_tooltip(_("No connection"));
}
} else if (mc.state == NM.ActiveConnectionState.ACTIVATING) {
new_delay = FAST_PERIODIC_UPDATE_FREQUENCY_SECONDS;
switch (mc._section) {
Expand Down
Loading