[WIP] Elimination of compile warnings#3617
Closed
kdmenk wants to merge 1 commit intolinuxmint:masterfrom
Closed
Conversation
found memory leak in nemo-places-sidebar.c in nemo_places_sidebar_dispose
mtwebster
reviewed
Nov 17, 2025
| //if (chunk != NULL) { | ||
| g_string_append_len (str, chunk, len); | ||
| } | ||
| //} |
Member
There was a problem hiding this comment.
Just delete the lines and unindent please, don't comment.
mtwebster
reviewed
Nov 17, 2025
|
|
||
| if (chunk != NULL) | ||
| // if (chunk != NULL) always true | ||
| { |
mtwebster
reviewed
Nov 17, 2025
| sidebar->uri = NULL; | ||
|
|
||
| g_clear_object (&sidebar->ui_manager); | ||
| sidebar->ui_manager = NULL; |
Member
There was a problem hiding this comment.
no need to set to NULL, g_clear_object already does this for you.
Member
There was a problem hiding this comment.
sidebar->ui_manager = NULL is redundant. This is what g_clear_object does, as opposed to g_object_unref, which does not:
mtwebster
changed the title
clefebvre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found memory leak in nemo-places-sidebar.c in nemo_places_sidebar_dispose. Only very small changes.
This is just a bugfix on the existing code base which I found during my implementation which will follow.