Restore symlink paths for letsencrypt keys #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Contributor
|
I am a bot, here is the pushed image/manifest for this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #549
Description:
Restore back the symlink as it was before the rebase here.
This will have no impact on the functionality, but the change broke installations where people relied on the path to resolve the keys outside the container (e.g. in Unraid, as indicated by #549). For example we point to other applications that need the keys to this path.
Also as /config is the absolute path where the volume is mounted inside the container, using the relative path makes more sense imho.
Benefits of this PR and context:
Fixes #549 - No impact on functionality.
How Has This Been Tested?
Tested on live system
Source / References:
Originally introduced during rebase here #526 (pinging @thespad)