Merged
Conversation
✅ Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Deploying livecodes with
|
| Latest commit: |
b672c62
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://11875449.livecodes.pages.dev |
| Branch Preview URL: | https://minimap.livecodes.pages.dev |
|
Contributor
|
Size Change: +444 B (+0.04%) Total Size: 1.04 MB ℹ️ View Unchanged
|
WalkthroughThis PR adds minimap functionality to the code editor across the entire stack. Changes include configuration defaults, validation, UI settings toggle, integrations with Codemirror and Monaco editors, vendor dependencies, translations, documentation, and SDK model updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/livecodes/editor/codemirror/codemirror.ts (1)
235-252:⚠️ Potential issue | 🟡 MinorGuard minimap activation for non-code editors (console/embed).
Line 235 currently enables minimap purely from user settings. Unlike Monaco, this can turn minimap on for console/embed flows in CodeMirror.
Proposed fix
- const enableMinimap = settings.minimap ?? editorSettings.minimap; + const enableMinimap = + (settings.minimap ?? editorSettings.minimap) && !['console', 'embed'].includes(editorId);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/livecodes/editor/codemirror/codemirror.ts` around lines 235 - 252, The minimap is currently enabled based only on enableMinimap and the presence of minimap; update the minimap activation clause to also guard against non-code editor flows (console/embed). Modify the expression that builds the extensions (the line using enableMinimap and minimap) to require an additional check such as editorMode not being 'console' or 'embed' (or a boolean like isCodeEditor if available) before including minimap.compute(...). Keep the rest of the minimap block unchanged and use the existing identifiers enableMinimap, minimap, and editorMode to locate and implement the guard.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/livecodes/editor/codemirror/codemirror.ts`:
- Around line 235-252: The minimap is currently enabled based only on
enableMinimap and the presence of minimap; update the minimap activation clause
to also guard against non-code editor flows (console/embed). Modify the
expression that builds the extensions (the line using enableMinimap and minimap)
to require an additional check such as editorMode not being 'console' or 'embed'
(or a boolean like isCodeEditor if available) before including
minimap.compute(...). Keep the rest of the minimap block unchanged and use the
existing identifiers enableMinimap, minimap, and editorMode to locate and
implement the guard.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
docs/docs/configuration/configuration-object.mdxdocs/docs/features/editor-settings.mdxsrc/livecodes/UI/editor-settings.tssrc/livecodes/config/config.tssrc/livecodes/config/default-config.tssrc/livecodes/config/validate-config.tssrc/livecodes/editor/codemirror/codemirror.tssrc/livecodes/editor/monaco/monaco.tssrc/livecodes/html/app.htmlsrc/livecodes/i18n/locales/en/translation.lokalise.jsonsrc/livecodes/i18n/locales/en/translation.tssrc/livecodes/main.tssrc/livecodes/vendors.tssrc/sdk/models.ts
Contributor
i18n ActionsSource PR has been merged into the default branch. Maintainers can comment |
Collaborator
Author
|
.i18n-update-push |
Contributor
i18n Actions:
|
| Name | Description |
|---|---|
| New Branch for i18n | i18n/live-codes/minimap |
| Last Commit SHA | b694eea |
Maintainers can comment .i18n-update-pull after translation is done to trigger the i18n pull workflow and pull the changes back to Github.
Collaborator
Author
|
.i18n-update-pull |
Contributor
i18n Actions:
|
| Name | Description |
|---|---|
| i18n Branch | i18n/live-codes/minimap |
| Last Commit SHA | 4d28e3a |
| i18n PR | #958 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows adding minimap in code editor (monaco and codemirror).
A new
minimapboolean config option is added (defaults tofalse).It can be set from the editor settings screen, config object or the
?minimapparamSummary by CodeRabbit