fix(voice): preserve turns across activity handoffs - #6844
Draft
IanCollection wants to merge 2 commits into
Draft
Conversation
|
ian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
During an
AgentTaskorupdate_agent()handoff, the source activity blocks scheduling before the successor is fully active. An EOU landing in that window currently follows thescheduling_pausedbranch, returnsTrue, and clears the recognition transcript without adding it to either activity's history. The user turn disappears.The queue is owned by the activity and moves across the concrete activity boundary. Successful successors consume it through
_user_turn_completed_task; terminal paths use the same history/metrics semantics as session close. Realtime models are intentionally excluded because their input commit lifecycle is remote and is covered separately by #6662.Impact
Cascade/
AgentTaskand serializedupdate_agent()handoffs retain a crossing user turn exactly once instead of silently dropping it.Design feedback requested
This PR implements the existing TODO in
on_end_of_turnby transferring ownership to the successor activity. Feedback is especially welcome on whether activity-owned buffering is the preferred framework boundary for chained handoffs.Validation
skipping user input, speech scheduling is pausedAgentTask, consecutiveupdate_agent(), successor close rejection, successor startup failure, and source closepytest tests/test_agent_task_handoff_turn.py tests/test_nested_agent_task.py tests/test_update_agent_long_on_enter.py tests/test_agent_task_close_race.py tests/test_foreground_run_tracking.py tests/test_agent_session.py --unit -q— 98 passedlivekit.agents) — 206 files passedRelated but distinct: #6662 fixes Realtime paused-speech/overlap behavior; this PR handles local pipeline turn ownership across activity replacement.