Skip to content

chore(preview): sync to the reviewed Effect PR - #336

Merged
lloydrichards merged 1 commit into
codex/vfs-review-seriesfrom
codex/sync-preview-pr-9960
Nov 16, 2026
Merged

lloydrichards merged 1 commit into
codex/vfs-review-seriesfrom
codex/sync-preview-pr-9960

Conversation

@lloydrichards

@lloydrichards lloydrichards commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Goal/Scope

Stack this sync on #335 and regenerate the private preview from Effect PR #9960 at 2bf24a366e275b6f000fe50a18c34a8f6a48b331. That revision contains all eleven reviewed VFS fixes.

Description

Refresh the offline snapshot and its checksums. Regeneration produces one source-tree difference from #335: the capture-order regression now gives the expected names explicitly. The generated runtime is byte-for-byte identical. The snapshot stays as the input to offline builds.

Comment

Review this PR against #335’s head. Core and Node adapter changes belong to the parent PR. C6 remains deferred.

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
effect-vfs-docs Ready Ready Preview Nov 16, 2026 4:31pm UTC

@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9b993ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lloydrichards
lloydrichards added this pull request to stack #337 November 16, 2026 16:10

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Reviewed the preview sync against codex/vfs-review-series and verified the affected checks.

  • Offline snapshot — Updates the pinned upstream revision to 2bf24a3 and the capture-test checksum; regeneration and drift/corruption checks pass.
  • Capture expectation — Lists the expected capture names explicitly; all 20 capture/restore tests pass.
  • Schema consumer — Uses Schema.decodeResult for the encoded value; generated TypeScript compilation and the byte-path round trip pass.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@lloydrichards
lloydrichards force-pushed the codex/sync-preview-pr-9960 branch from 6fe5dc6 to 9b993ef Compare November 16, 2026 16:21
@lloydrichards
lloydrichards merged commit 0d51e97 into main Nov 16, 2026
12 checks passed
@lloydrichards
lloydrichards deleted the codex/sync-preview-pr-9960 branch November 16, 2026 16:36

This branch was successfully deployed

1 active deployment
Preview — 9b993efc Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant