Skip to content

fix: get CI green and add integration tests#21

Merged
HarshCasper merged 3 commits intomainfrom
fix/yq-install-ci
May 5, 2026
Merged

fix: get CI green and add integration tests#21
HarshCasper merged 3 commits intomainfrom
fix/yq-install-ci

Conversation

@HarshCasper
Copy link
Copy Markdown
Member

@HarshCasper HarshCasper commented Apr 27, 2026

Summary

Get this sample working again on LocalStack and in CI. Fixes DEVREL-194

CI fixes

  • Install yq: replace the dead ppa:rmescandon/yq (no Release file for Ubuntu noble) with the upstream mikefarah/yq binary from GitHub releases. This was the original failure on main.
  • Integration test step: after the deploy completes, look up ApiBasePath from the sam-app stack outputs, curl both /no-proxy and /proxy via the LocalStack API Gateway URL, and assert the response contains a PostgreSQL version row. CI now fails if either lambda can't reach the cluster or proxy IAM auth is broken — not just if the deploy succeeds.

Template fixes (rds-with-proxy.yaml)

The Aurora PostgreSQL stack was rolling back on pgNodeParams and would have failed proxy auth even if it hadn't:

  • dbFamily: aurora-postgresql13.4 (invalid family) → aurora-postgresql13
  • dbVersion: 13.4 (unsupported) → 13.16
  • pgNodeParams: drop MySQL parameters (innodb_stats_persistent_sample_pages, slow_query_log, long_query_time, log_output) and replace with postgres equivalents (log_min_duration_statement, log_statement).
  • dbCluster: drop MySQL-only BacktrackWindow; switch EnableCloudwatchLogsExports from [error, slowquery] to [postgresql].
  • dbProxy.EngineFamily: MYSQLPOSTGRESQL.

The rmescandon/yq PPA has no Release file for Ubuntu noble (24.04),
causing CI to fail. Download the binary directly instead.
Fixes deploy rollback caused by stale settings:
- dbFamily aurora-postgresql13.4 (invalid) -> aurora-postgresql13
- dbVersion 13.4 (unsupported) -> 13.16
- pgNodeParams: replace MySQL params with postgres equivalents
- dbCluster: drop MySQL-only BacktrackWindow, switch
  EnableCloudwatchLogsExports from [error,slowquery] to [postgresql]
- dbProxy EngineFamily MYSQL -> POSTGRESQL
Curl both API Gateway routes after deploy and assert each returns
a PostgreSQL version row, so CI fails if the lambdas can't reach
the cluster or the proxy IAM auth is broken.
@HarshCasper HarshCasper changed the title fix: install yq from GitHub releases fix: get CI green and add integration tests Apr 27, 2026
@HarshCasper HarshCasper requested a review from remotesynth April 27, 2026 06:57
@HarshCasper HarshCasper merged commit 868e016 into main May 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants