Conversation
* Add LocalStack WireMock extension that runs/proxies a WireMock container * Add sample app for integration testing * Add GitHub Actions workflow for extension tests
| # TODO: merge utils with code in TypeDB extension over time ... | ||
|
|
||
|
|
||
| class ProxiedDockerContainerExtension(Extension): |
There was a problem hiding this comment.
FYI (note to self) - we've recently merged a similar version of this class for the TypeDB extension. Over time we could move that class as a common utility into the core codebase (either in localstack repo, or as a separate localstack-extensions pypi package). /cc @purcell
See the TODO comment a few lines above - we should tackle this in a follow-up iteration.. 馃憤
There was a problem hiding this comment.
See draft PR here: #123 Will work on externalizing the utils and updating the Wiremock extension after merging this PR. 馃憤
| #!/usr/bin/env node | ||
| import "source-map-support/register"; | ||
| import * as cdk from "aws-cdk-lib"; | ||
| import { ChatStack } from "../lib/chat-stack"; |
There was a problem hiding this comment.
Getting an error when running cdklocal deploy locally - @HarshCasper is it possible that the chat-stack.ts file hasn't been included in the PR?
There was a problem hiding this comment.
Sorry, the .gitignore was set to ignore the lib/ directory. Its now fixed and the chat-stack.ts should be visible here.
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
|
Thanks @remotesynth @HarshCasper for updating the PR! Just wanted to confirm - is the extension startup working for you right now? I'm still getting this error in the logs of the wiremock-runner container - seems like it could be an issue in the contents of the Is this working for you all e2e? |
whummer
left a comment
There was a problem hiding this comment.
Approving the PR, as it seems to be working for Harsh and Brian locally. 馃憤 Will merge and release the extension to pypi now, so we can continue with preparing the meetup demo. (will try to fix my local setup separately..)
Great job - excited to see this being released! 馃殌
Originally authored by @whummer