[codex] Fix wasm pre-commit aliasing in barrier APIs#939
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a
loro-wasmre-entrancy issue on pre-commit/barrier paths that could surface as:Error: recursive use of an object detected which would lead to unsafe aliasing in rustimportBatchwas already present in the JS-side pending-event decoration allowlist. The actual problem was that several WASM-exposedLoroDocmethods still took&mut self, even though the underlying Rust APIs only require&selfand can synchronously re-enter JS throughsubscribePreCommit.What Changed
attach,checkoutToLatest,checkout,importUpdateBatch, andimportBatchto take&selfin the wasm binding layerimportBatchpending-event flushingimportBatch,checkoutToLatest, andattachwhen asubscribePreCommitcallback touches the samedocRoot Cause
The JS decoration list was not the missing piece here.
importBatchis already decorated on the JS side, so pending events are flushed correctly after the call returns. The unsafe aliasing error comes from a different path:subscribePreCommitinvokes JS synchronously before the outer WASM call finishes. If that outer binding holds a mutable wasm-bindgen borrow, touching the same document again from the callback can trigger the recursive aliasing error.Impact
This makes the affected
loro-wasmAPIs safe to re-enter from pre-commit callbacks and prevents false attribution of the bug to the pending-event decoration list.Validation
pnpm --dir crates/loro-wasm test