Repository navigation
Document resize kernels with a side-by-side comparison #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sivashankarav
wants to merge
2
commits into
lovell:main
Choose a base branch
from
sivashankarav:docs-resize-kernel-comparison
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /*! | ||
| Copyright 2013 Lovell Fuller and others. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| // Rebuild docs/public/api-resize-kernels.png from a high-contrast diagonal. | ||
| // Rasterise the SVG at 1280x960 first, then downsize the same PNG to 160x120. | ||
| import { fileURLToPath } from 'node:url'; | ||
| import path from 'node:path'; | ||
| import sharp from '../../lib/index.mjs'; | ||
|
|
||
| const root = path.resolve(fileURLToPath(new URL('../..', import.meta.url))); | ||
| const input = Buffer.from(`<svg xmlns="http://www.w3.org/2000/svg" width="1280" height="960" viewBox="0 0 1280 960"> | ||
| <rect width="1280" height="960" fill="white"/> | ||
| <path d="M0 760 L1000 0 H1280 L0 960Z" fill="#111"/> | ||
| <path d="M0 250 L1280 900" fill="none" stroke="#111" stroke-width="24"/> | ||
| <path d="M150 0 L1280 570" fill="none" stroke="#e84428" stroke-width="8"/> | ||
| </svg>`); | ||
| // Resizing SVG input directly rasterises at the output size and ignores the kernel. | ||
| const raster = await sharp(input).png().toBuffer(); | ||
| const output = path.join(root, 'docs/public/api-resize-kernels.png'); | ||
| const kernels = [ | ||
| 'nearest', 'linear', 'cubic', 'mitchell', | ||
| 'lanczos2', 'lanczos3', 'mks2013', 'mks2021' | ||
| ]; | ||
| const width = 176; | ||
| const height = 154; | ||
| const imageWidth = 160; | ||
| const imageHeight = 120; | ||
| const panels = await Promise.all(kernels.map(async (kernel, index) => { | ||
| const image = await sharp(raster) | ||
| .resize(imageWidth, imageHeight, { kernel, fastShrinkOnLoad: false }) | ||
| .png() | ||
| .toBuffer(); | ||
| const label = Buffer.from(`<svg width="${width}" height="28" xmlns="http://www.w3.org/2000/svg"><text x="8" y="21" font-size="17" font-family="sans-serif" fill="#16181d">${kernel}</text></svg>`); | ||
| const x = (index % 4) * width; | ||
| const y = Math.floor(index / 4) * height; | ||
| return [ | ||
| { input: image, left: x + 8, top: y + 28 }, | ||
| { input: label, left: x, top: y } | ||
| ]; | ||
| })); | ||
| await sharp({ create: { width: width * 4, height: height * 2, channels: 4, background: '#fff' } }) | ||
| .composite(panels.flat()) | ||
| .png() | ||
| .toFile(output); | ||
| console.log(output); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An SVG input used with
resizewill be rasterised at the specified dimensions andkernelwill be ignored, which is why the 8 parts of the image in the PR all look the same. (I should probably add something to the docs about this short-cut.)I think you'll need to render the SVG as PNG using the full 1280x960 dimensions then use a second pipeline to resize down using the various kernels.