fixed misa cosim override for different Ibex configs#1988
Draft
Saad525 wants to merge 1 commit intolowRISC:masterfrom
Draft
fixed misa cosim override for different Ibex configs#1988Saad525 wants to merge 1 commit intolowRISC:masterfrom
Saad525 wants to merge 1 commit intolowRISC:masterfrom
Conversation
Saad525
force-pushed
the
misa_override_fix
branch
2 times, most recently
from
f493dfd to
7fc35ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue caught by a random test failing in CI run.
misa CSR value is different for various Ibex configs. So, the override should not hardcode all the bits.
I have updated the mask to ignore some of the bits depending on specific Ibex config.