-
Notifications
You must be signed in to change notification settings - Fork 1
[WEB-8149] fix(badge): support icon-only badges with proper accessibility #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codingwolf-at
wants to merge
5
commits into
main
Choose a base branch
from
fix/badge-design-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0c00eed
refactor(badge): enhance icon-only badge functionality and update sto…
codingwolf-at 12a77ad
fix(badge): update success and warning variant text colors for consis…
codingwolf-at 83bee32
fix(badge): enhance accessibility for icon-only badges
codingwolf-at 9dc386f
fix(badge): improve accessibility and update variant colors
codingwolf-at 6466b09
feat(badge): add 'info' tone and enhance badge variants
codingwolf-at File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only documents the
aria-labelrequirement: callers can still omit bothlabelandaria-label, producing an unnamedrole="img". Could we model the label/icon-only cases as a union so the accessible name is required here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Modeled BadgeProps as a discriminated union so the name is required either way:
Labeled → named by its text; icon-only (no label) → aria-label required at compile time, so omitting both is now a type error instead of a silent unnamed role="img". Went with a union rather than the aria-hidden fallback used for Avatar because an icon-only badge is meaningful status — it should be named, not hidden. Type-check confirms all existing usages already pass a name.