mem_space: support accesses with an offset#10
Open
Qwinci wants to merge 1 commit intomanagarm:masterfrom
Open
Conversation
Member
|
There are some alternatives to this that are worth considering:
|
Member
|
Is still useful to have functions that take an offset despite these alternatives being available? I'm not necessarily against the new functions but I'd like some justification why the existing approaches are inconvenient. |
Author
|
I guess the approach with a function is pretty nice, I didn't think of that. The functions that take in offsets aren't probably needed over that though I think they could possibly still be a nice option for e.g. registers where the offset depends on multiple runtime variables (as in that case for the function approach you'd have to either pass multiple parameters/have it as a member function and the subspace method is kinda long). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add versions of read/write that take in an additional offset. It is useful for accessing register arrays, previously you had to do something like
whereas with this change you can do