-
Notifications
You must be signed in to change notification settings - Fork 22
Fix/mlwmsloader layer switch #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes layer switching functionality in the MlWmsLoader component and refactors the sortable container implementation.
Changes:
- Modified SortableContainer to use dynamic UUIDs instead of layer IDs for drag-and-drop functionality
- Enhanced MlWmsLoader with new props for controlling layer visibility, feature info callbacks, and UI display
- Updated MlWmsLayer to simplify layer initialization and improve source change detection
- Upgraded maplibre-gl dependency and updated test assertions to use newer API methods
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SortableContainer.tsx | Removed layerId prop and switched to UUID-based IDs for sortable items |
| LayerListItem.tsx | Updated to pass children without layerId prop to SortableContainer |
| MlWmsLoader.tsx | Added visibility control, feature info callbacks, and conditional layer list rendering |
| MlWmsLayer.tsx | Simplified layer initialization logic and improved source update detection |
| MlTerrainLayer.cy.tsx | Updated test assertions from sourceCaches to getSource API |
| package.json | Upgraded maplibre-gl from 5.7.0 to 5.16.0 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.