Skip to content

Fix vertical bearing calculation#636

Merged
oscarlorentzon merged 1 commit intomainfrom
feature-bearing-calc
Apr 30, 2025
Merged

Fix vertical bearing calculation#636
oscarlorentzon merged 1 commit intomainfrom
feature-bearing-calc

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Apr 30, 2025

Contribution

Filter points behind the principal plane to ensure calculation is accurate for fisheyes that with fov larger than 180 degrees.

Test Plan

yarn test
yarn build
yarn start

@oscarlorentzon
feat: fix vertical bearing calculation
ec53127 
Filter points behind the principal plane.
@oscarlorentzon oscarlorentzon added this to the v5.0.0 milestone Apr 30, 2025
@oscarlorentzon oscarlorentzon self-assigned this Apr 30, 2025
@oscarlorentzon oscarlorentzon merged commit a0d7bc7 into main Apr 30, 2025
5 checks passed
@oscarlorentzon oscarlorentzon deleted the feature-bearing-calc branch April 30, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oscarlorentzon oscarlorentzon

Labels

cla signed

Projects

None yet

Milestone

v5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@oscarlorentzon @facebook-github-bot