client: Add option to only bridge DMs - #93
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “DM-only” operating mode for the Slack connector, intended to restrict discovery/sync/event handling to direct messages (IMs) and group DMs (MPIMs), while omitting channel data where possible.
Changes:
- Introduces
dm_onlyconfiguration and config upgrader support. - Uses Slack client boot options to omit channel data when
dm_onlyis enabled. - Filters incoming Slack events and adjusts channel sync logic to ignore non-DM conversations in DM-only mode.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/connector/startchat.go | Blocks channel creation when dm_only is enabled. |
| pkg/connector/login-cookie.go | Uses boot options to omit channels during cookie/token login when dm_only is enabled. |
| pkg/connector/handleslack.go | Filters events to DM channels only; adds helper to extract channel ID from events. |
| pkg/connector/example-config.yaml | Documents the new dm_only config option. |
| pkg/connector/config.go | Adds DMOnly to config struct and config upgrade path. |
| pkg/connector/client.go | Tracks DM channel IDs; boots and syncs differently under dm_only. |
| pkg/connector/capabilities.go | Hides public/private channel creation capability when dm_only is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for _, ch := range s.BootResp.Channels { | ||
| ch.IsMember = true | ||
| channels = append(channels, &ch.Channel) | ||
| if s.Main.Config.DMOnly || (s.IsRealUser && (strings.HasPrefix(token, "xoxs-") || s.Main.Config.Backfill.ConversationCount == -1)) { |
e300778 to
dbe2271
Compare
| } | ||
| // TODO do actual warm boots by saving last received ts somewhere | ||
| bootResp, err = s.Client.ClientUserBootContext(ctx, time.Time{}) | ||
| bootResp, err = s.Client.ClientUserBootContext(ctx, time.Time{}, s.Main.Config.DMOnly) |
There was a problem hiding this comment.
slack is actually ignoring omit_channels and still returning it. keeping it in case bot logins are different
There was a problem hiding this comment.
userBoot is only used for users, never bots
| pages := 0 | ||
| output = make(map[networkid.UserID]bridgev2.ChatMember) | ||
| for limit > 0 { | ||
| chunkLimit := limit |
There was a problem hiding this comment.
bug in main - chunkLimit was unused
| const maxSlackPaginationPages = 1000 | ||
|
|
||
| func slackPageLimit(unlimited bool, remaining int) int { | ||
| const maxPage = 200 |
There was a problem hiding this comment.
@tulir any reason to do 200 max here? i tested users.conversations accepts limit=999 (it returned my 828 DMs/MPIMs in 1 req)
this will reduce users.conversations from 5 requests to 1 for me
There was a problem hiding this comment.
I assume it's from what the web app does, but probably fine to increase. I don't think slack bans users since most people are paying them
|
@tulir good for re-review |
tulir
changed the title
tulir
left a comment
tulir
left a comment
There was a problem hiding this comment.
The omit_channels thing could be reverted since it's not used for bots, but otherwise looks fine
| const maxSlackPaginationPages = 1000 | ||
|
|
||
| func slackPageLimit(unlimited bool, remaining int) int { | ||
| const maxPage = 200 |
There was a problem hiding this comment.
I assume it's from what the web app does, but probably fine to increase. I don't think slack bans users since most people are paying them
| } | ||
| // TODO do actual warm boots by saving last received ts somewhere | ||
| bootResp, err = s.Client.ClientUserBootContext(ctx, time.Time{}) | ||
| bootResp, err = s.Client.ClientUserBootContext(ctx, time.Time{}, s.Main.Config.DMOnly) |
There was a problem hiding this comment.
userBoot is only used for users, never bots
Depends on beeper/slackgo#4