Validate package API against the latest release#445
Merged
horgh merged 2 commits intoJul 23, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 22, 2026
oschwald
force-pushed
the
greg/stf-55-breaking-changes-are-detected-on-net-repos
branch
from
July 22, 2026 21:31
5b72485 to
7f129a1
Compare
Without a baseline version, package validation only runs the compatible-TFM validators; it does not compare the package against the previously published release, so an accidental breaking API change still packs successfully. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bumping the baseline to the new version after the tag is created keeps pull requests validated against the latest published release, while the tagged commit itself is still validated against the release it replaces. Bumping before tagging would not work: the new version is not on NuGet when the release build packs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
oschwald
force-pushed
the
greg/stf-55-breaking-changes-are-detected-on-net-repos
branch
from
July 22, 2026 21:32
7f129a1 to
9f05226
Compare
horgh
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set
PackageValidationBaselineVersionto 6.1.0 (the latest published release) inMaxMind.MinFraud.csproj, and updatedev-bin/release.shto bump the baseline to the new version right after tagging a release.Why
EnablePackageValidationon its own (#429) only runs the compatible-TFM validators; it does not compare the package against the previously published release, so an accidental breaking API change still packs successfully. WithPackageValidationBaselineVersionset,dotnet packdownloads the baseline package from NuGet and fails on binary- or source-incompatible changes. Since the release workflow runsdotnet packon every pull request, accidental breaking changes are caught in CI (STF-55).The baseline is bumped after tagging so that pull requests are always validated against the latest published release, while the tagged commit itself is validated against the release it replaces (the new version is not yet on NuGet when the release build packs). One caveat: packs that run in the few minutes between tagging and the package becoming downloadable from NuGet can fail transiently; a re-run fixes them.
This is the follow-up discussed in #429: MaxMind.MinFraud 6.1.0 has since been published, so there is now a real baseline to validate against.
Verified locally: making
Warning.Codeinternal failsdotnet packwithCP0002against the 6.1.0 baseline for every TFM, and the unmodified branch packs cleanly. Intentional breaking changes (e.g., for a future major release) can be recorded withdotnet pack /p:ApiCompatGenerateSuppressionFile=true.This PR is stacked on #429 (base branch
enable-package-validation).🤖 Generated with Claude Code