Skip to content

Expand email alias domain lists - #1932

Open
faktas2 wants to merge 1 commit into
mainfrom
expand-email-alias-domains
Open

Expand email alias domain lists#1932
faktas2 wants to merge 1 commit into
mainfrom
expand-email-alias-domains

Conversation

@faktas2

@faktas2 faktas2 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds two newly identified alias domains so more equivalent addresses
normalize to the same value before hashing:

  • fastmail.ca — Fastmail's own Canadian domain. Confirmed via MX
    records resolving to Fastmail's messagingengine.com infrastructure,
    and listed on Fastmail's official domain list.
  • myyahoo.com — an alternate Yahoo-owned signup domain (WHOIS
    registrant: Yahoo Assets LLC), functionally identical to yahoo.com.

Both run on their provider's own native mail platform with no
third-party migration history, so the existing normalization logic
applies to them exactly as it does to their canonical counterparts.

This mirrors the same addition made to the minFraud web service's own
email normalization.

Testing

49/49 tests pass (npx vitest run).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved email normalization for Fastmail addresses using fastmail.ca.
    • Improved email normalization for Yahoo addresses using myyahoo.com.
    • Added coverage to verify correct domain handling and generated hashes for these cases.

Add fastmail.ca to the Fastmail domain set and myyahoo.com to the
Yahoo domain set, so more equivalent addresses normalize to the same
value before hashing. Both are confirmed to run on their provider's
own mail platform with no third-party migration history.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1d6bd983-997a-478d-8e4e-96f4ff224daf

📥 Commits

Reviewing files that changed from the base of the PR and between 5d84d6f and a4a1904.

📒 Files selected for processing (2)
  • src/request/email.spec.ts
  • src/request/email.ts

📝 Walkthrough

Walkthrough

Email normalization now recognizes fastmail.ca and myyahoo.com, with tests verifying alias removal, normalized domains, and hashed addresses.

Changes

Email normalization

Layer / File(s) Summary
Extend domain normalization coverage
src/request/email.ts, src/request/email.spec.ts
The Fastmail and Yahoo domain allowlists include fastmail.ca and myyahoo.com; tests verify normalized domains and MD5-hashed addresses for corresponding aliases.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: kevcenteno

Poem

I’m a rabbit with aliases tucked neat,
Two new domains now hop to the beat.
Hashes grow tidy, domains stay bright,
Fastmail and Yahoo normalize right.
Nibble, test, and ship tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: expanding email alias domain lists for normalization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch expand-email-alias-domains

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant