Skip to content

[MOO-2466]: Fix BottomSheet deprecated prop #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MxKevinBeqo wants to merge 2 commits into
base: mx/11.12.x
Choose a base branch
from
Open

[MOO-2466]: Fix BottomSheet deprecated prop #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
585aaf7
fix(bottom-sheet-native): update deprecated prop with new one
MxKevinBeqo Sep 4, 2026
d58b4f9
chore(bottom-sheet-native): add release notes and bump version
MxKevinBeqo Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/bottom-sheet-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- Replaced a deprecated prop 'containerHeight' with the respective 'containerLayoutState' option.

## [5.3.2] - 2026-8-4

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/bottom-sheet-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "bottom-sheet-native",
"widgetName": "BottomSheet",
"version": "5.3.2",
"version": "5.3.3",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
11 changes: 10 additions & 1 deletion packages/pluggableWidgets/bottom-sheet-native/src/components/CustomModalSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ReactElement, ReactNode, useCallback, useEffect, useRef, useState } from "react";
import { Modal, Pressable, useWindowDimensions } from "react-native";
import { useSharedValue } from "react-native-reanimated";
import BottomSheet, {
BottomSheetBackdrop,
BottomSheetBackdropProps,
Expand All @@ -17,6 +18,14 @@ interface CustomModalSheetProps {
export const CustomModalSheet = (props: CustomModalSheetProps): ReactElement => {
const bottomSheetRef = useRef<BottomSheet>(null);
const { height: windowHeight } = useWindowDimensions();
const containerLayout = useSharedValue({
height: windowHeight,
offset: { top: 0, bottom: 0, left: 0, right: 0 }
});

useEffect(() => {
containerLayout.value = { height: windowHeight, offset: { top: 0, bottom: 0, left: 0, right: 0 } };
}, [windowHeight, containerLayout]);

const externalOpen =
props.triggerAttribute?.status === ValueStatus.Available && props.triggerAttribute.value === true;
Expand Down Expand Up @@ -86,7 +95,7 @@ export const CustomModalSheet = (props: CustomModalSheetProps): ReactElement =>
animateOnMount
enableDynamicSizing
maxDynamicContentSize={maxHeight}
containerHeight={windowHeight}
containerLayoutState={containerLayout}
enablePanDownToClose
onChange={handleChange}
onClose={() => handleChange(-1)}
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/bottom-sheet-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="BottomSheet" version="5.3.2" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="BottomSheet" version="5.3.3" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="BottomSheet.xml" />
</widgetFiles>
Expand Down
Loading