feat(popup-menu-web): click close on#2084
Open
Carter-Moorse wants to merge 4 commits intomendix:mainfrom
Open
Conversation
Added Close on property, which follows from Open on, type 'Click'. This new property has two options: - 'Click anywhere' - Closes when user clicks anywhere on page - 'Click outside' - Closes when user clicks outside the menu
Update changelog to include 4.1.0 changes
Updated version in package XML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Added Close on setting, for Open on type 'Click'.
This new property has two options:
What should be covered while testing?
clickCloseOnproperty, when set to:onClickAnywhere- expect popup to close when clicked anywhere on pageonClickOutside- expect popup to only close when clicked outside the menu