Client tests

[MarhiievHE]

Update client test

[tshemsedinov]

Is it subject to close #204 in favour of this PR?

[MarhiievHE]

@tshemsedinov Perhaps partially. Maybe it will be better if @leonpolak looks at whether everything is present, what he expected. I did not look at PR #204, but just corrected what interfered with the work of the test.
PS: I gave access to changes to my Fork.

[tshemsedinov]

Final version before landing should not contain commented console.log's

[MarhiievHE]

ok, do I need to remove all commented code too?

[tshemsedinov]

Just before landing, or you can add comment // not for landing if you added something not related to this PR or commented something just to make this code works but if it should be subject to separate PR

[tshemsedinov]

Looks like redis can't be accessed in docker: unhandledRejection: Error: connect ECONNREFUSED 127.0.0.1:6379
@MarhiievHE

[MarhiievHE]

Looks like redis can't be accessed in docker: unhandledRejection: Error: connect ECONNREFUSED 127.0.0.1:6379 @MarhiievHE

You are right, I have forgotten to add optional support running API under a container with Redis. Ok, I will add a config for Redis.

[MarhiievHE]

@tshemsedinov Do you have any other suggestions to improve or add some more tests?

[tshemsedinov]

@tshemsedinov Do you have any other suggestions to improve or add some more tests?

Tests are still failing https://github.com/metarhia/Example/pull/225/checks

[MarhiievHE]

@tshemsedinov Do you have any other suggestions to improve or add some more tests?

Tests are still failing https://github.com/metarhia/Example/pull/225/checks

It's because the test.yml haven't any instance of Redis in the test environment.

[MarhiievHE]

@leonpolak @tshemsedinov
I rewrote the test to use a node test runner and fixed a subscription check. And I also corrected the GitHub Actions script. Now, all tests are completed correctly.

[MarhiievHE]

@leonpolak Did you talk about this error before? I caught it too now with node version 18.

19:59:09  W2   error   warning: MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 Symbol() listeners added to [MetaReadable]. Use emitter.setMaxListeners() to increase limit
  _addListener (node:events:587:17)
  MetaReadable.addListener (node:events:605:10)
  MetaReadable.once (node:events:649:8)
  eventTargetAgnosticAddListener (node:events:1004:15)
  node:events:966:5
  new Promise (<anonymous>)
  Function.once (node:events:949:10)
  MetaReadable.push (/node_modules/metacom/lib/streams.js:45:26)
  Server.binary (/node_modules/metacom/lib/server.js:300:18)