Upload directories of files, with hooks to rewrite text either way - #137
Merged
Conversation
A `files` entry naming a directory can now carry a `source` directory,
and `upload` sends every file under it, creating in Crowdin any it lacks.
`status` reports each of them too.
`beforeUpload(text, { name })` rewrites the English before it is compared
and sent; `afterDownload(text, { name, language })` rewrites a downloaded
file before it is written. Together they keep a value that changes with
every release out of Crowdin. pxt-microbit-ml's help pages pin the
extension's version in a code block Crowdin treats as a string, so each
release would otherwise change the source and unsettle the translation;
its upload puts a placeholder there and its download restores the version
from the English page.
`--only` takes a directory with a trailing slash and names an entry that
matches nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
filesentry naming a directory can now carry asourcedirectory, anduploadsends every file under it, creating in Crowdin any it lacks.statusreports each of them too.beforeUpload(text, { name })rewrites the English before it is compared and sent;afterDownload(text, { name, language })rewrites a downloaded file before it is written. Together they keep a value that changes with every release out of Crowdin. pxt-microbit-ml's help pages pin the extension's version in a code block Crowdin treats as a string, so each release would otherwise change the source and unsettle the translation; its upload puts a placeholder there and its download restores the version from the English page.--onlytakes a directory with a trailing slash and names an entry that matches nothing.