added ML-For-Beginners and contribution_plan.md and contribut… - #142
added ML-For-Beginners and contribution_plan.md and contribut…#142Richard Ogundele (richardogundele) wants to merge 2 commits into
Conversation
|
@microsoft-github-policy-service agree comapny ="no company required" |
Manya Sharma (ManyaS-Git)
left a comment
There was a problem hiding this comment.
This PR is the third duplicate of the same change set as #175 and #167, and it contains the same critical security problem. It must not be merged in this state.
1. (CRITICAL — security) Third-party production site with live credentials committed to the repo
ai200-architectures/TrainDistributedDeepModel is a valid submodule (gitlink d037c56…) declared in .gitmodules. This PR deletes that gitlink and replaces it with a ~100 KB base64-encoded blob that decodes to a dumped HTML page of the production SaaS site alpha.duality.dev. Decoded, it contains live secrets: a GITHUB_CLIENT_SECRET/GITHUB_CLIENT_ID, NETLIFY_PUBLIC_NETLIFY_CLIENT_SECRET/_ID, a POSTHOG_KEY/POSTHOG_HOST, a SENTRY_DSN, session/access tokens, internal ENV/routing state, and a personal user record (email, invite code, plan data).
Committing this to a public repo exposes third-party production credentials. Please:
- Remove the blob and restore the
TrainDistributedDeepModelsubmodule pointer. - Treat all values in that blob as compromised — do not paste them into this thread.
- Notify the operator of
alpha.duality.devso they can rotate every exposed credential (GitHub/Netlify OAuth secrets, PostHog/Sentry keys, session tokens). - Run secret scanning (e.g.,
gitleaks) on the branch before any further changes.
2. Duplicate of #175 and #167
#142, #167, and #175 carry essentially the same change set (portal app, LICENSE edit, ML-For-Beginners gitlink, contribution_plan.md/contribution_tracker.md, the leaked blob, CI whitespace cleanup). All three are still open. Please consolidate into one PR and close the others — otherwise a security review can only ever cover one of three merge paths, and the incident could land through whichever one merges first.
3. Scope (49 files) and unrelated LICENSE edit
One PR again mixes a full React/Vite app, 23 .ci/* whitespace edits, docs, images, .github, LICENSE, submodules, and personal planning docs. contribution_plan.md/contribution_tracker.md reference issues in other repositories and read as personal planning notes — they don't belong in this repository. The LICENSE change (de-indenting the first line) should be reverted; license files shouldn't be touched without maintainer sign-off.
4. Submodule integrity
.gitmodulesstill declaresai200-architectures/TrainDistributedDeepModel, but the gitlink is gone — the submodule will fail to initialize.ML-For-Beginnersis added as a gitlink (f925c9a…) but is not registered in.gitmodules, sogit submodule update --initwon't include it.
5. The portal app won't build as written
src/data/resources.ts uses icon: ActivityIcon (seismic-dl entry) but ActivityIcon is not imported — a compile error under the strict-mode tsconfig this PR enables. icon?: any also undercuts strict typing, and no lockfile is committed for a buildable frontend.
Recommendation: do not merge. Remove the leaked blob and restore the submodule, revert LICENSE, register (or drop) ML-For-Beginners, consolidate this with #167/#175 into one PR, and split the app from the CI/doc changes. Happy to re-review a cleaned-up version.
…ion_tracker.md