enchancemet - #179
Conversation
Manya Sharma (ManyaS-Git)
left a comment
There was a problem hiding this comment.
This change is mostly a regression and shouldn't be merged as-is. The intent seems to be a grammar cleanup of .docs/python_scoring.md, but it introduces a broken link, breaks a paragraph, and leaves genuine grammar errors.
1. (Blocker) It breaks a URL.
-…[AzureML Pipelines w/GPU](https://github.com/Azure/Batch-Scoring-Deep-Learning-Models-With-AML)
+…[AzureML Pipeline w/GPU](https://github.com/Azure/Batch-Scoring-Deep-Learning-Model-With-AML)
You changed the link target from …-Models-With-AML to …-Model-With-AML (singular). I verified via the GitHub API: Azure/Batch-Scoring-Deep-Learning-Models-With-AML exists (it now redirects to microsoft/az-deep-batch-score), while Azure/Batch-Scoring-Deep-Learning-Model-With-AML returns 404. Please never change a URL while editing prose — restore the original link.
2. Mid-sentence line breaks break the paragraph.
+… For a tutorial on deploying classical ML model
+
+
+ for real time scoring look [AKS](…)…
The two blank lines split one sentence across three fragments, which renders as detached lines. The original was a single flowing paragraph.
3. The "grammar fix" is internally inconsistent.
- "When deploying ML model in Python" (singular) but "For deploying deep learning models" (plural) a few words later — same inconsistency now exists between "ML model" and "deep learning models".
- "deep learning model that require real time" — subject/verb disagreement introduced by making "model" singular while keeping "require".
- "with GPU" vs "with GPUs" and "Pipeline" vs "Pipelines" are now inconsistent within the same paragraph.
4. It doesn't fix the actual bug in this file.
The image path <img src="../images/decision_python_scoring.png"> is still the broken images/ path (issue #128 — the directory is .images/, and PR #129 already fixes this). This PR is based on older master, so it will conflict with #129 and undo nothing useful here.
5. Hygiene.
- The PR ends the file with no trailing newline again (
\ No newline at end of file). - Title has a typo ("enchancemet") and the description is placeholder text ("bcnvv").
Recommendation: request changes — restore the original URL and the single-paragraph structure, keep the existing "models/GPUs" plural wording, and rebase on top of the images/→.images/ fix from #129 (or just close this and leave the prose as-is; the original text wasn't wrong).
bcnvv