-
Notifications
You must be signed in to change notification settings - Fork 381
[Subcontracting] Use Base Unit of Measure for WIP Ledger Entries #8585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b4ff271
1eb3e61
1202734
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -238,6 +238,8 @@ codeunit 139983 "Subc. Management Library" | |||||||||||
| end; | ||||||||||||
|
|
||||||||||||
| procedure CreateWIPLedgerEntry(var WIPLedgerEntry: Record "Subcontractor WIP Ledger Entry"; ItemNo: Code[20]; LocationCode: Code[10]; ProductionOrder: Record "Production Order"; ProdOrderLine: Record "Prod. Order Line"; ProdOrderRoutingLine: Record "Prod. Order Routing Line"; WorkCenterNo: Code[20]; QuantityBase: Decimal; InTransit: Boolean) | ||||||||||||
| var | ||||||||||||
| Item: Record Item; | ||||||||||||
| begin | ||||||||||||
| if WIPLedgerEntry.FindLast() then; | ||||||||||||
| WIPLedgerEntry.Init(); | ||||||||||||
|
|
@@ -253,7 +255,9 @@ codeunit 139983 "Subc. Management Library" | |||||||||||
| WIPLedgerEntry."Work Center No." := WorkCenterNo; | ||||||||||||
| WIPLedgerEntry."Quantity (Base)" := QuantityBase; | ||||||||||||
| WIPLedgerEntry."In Transit" := InTransit; | ||||||||||||
| WIPLedgerEntry."Unit of Measure Code" := ProdOrderLine."Unit of Measure Code"; | ||||||||||||
| Item.SetLoadFields("Base Unit of Measure"); | ||||||||||||
| if Item.Get(ItemNo) then | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incomplete WIP entry when Item.Get fails in libraryThe same silent-skip pattern used in production code is repeated in Recommendation:
Suggested change
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why |
||||||||||||
| WIPLedgerEntry."Base Unit of Measure" := Item."Base Unit of Measure"; | ||||||||||||
| WIPLedgerEntry.Insert(); | ||||||||||||
| end; | ||||||||||||
| } | ||||||||||||
Uh oh!
There was an error while loading. Please reload this page.