[QM] Fixed Silent Failure in UpdateFullTextRuleStringsFromFilters#8596
Open
6CRIPT wants to merge 1 commit into
Open
[QM] Fixed Silent Failure in UpdateFullTextRuleStringsFromFilters#85966CRIPT wants to merge 1 commit into
6CRIPT wants to merge 1 commit into
Conversation
…e first clear the last error and then if the filter updating fails we show an error explaining it.
JakovljevicDusan
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JustPutAways, Assembly Description and Manufacturing Description
fields called the UpdateFullTextRuleStringsFromFilters TryFunction in
their OnValidate trigger but ignored its return value, so invalid filter
configurations were silently accepted.
Now the 3 fields follow the same pattern as the correct ones: we first
clear the last error and then, if updating the filters fails, we show an
error explaining the problem.
Fixes AB#620346