Remove obsolete SGX add_node_code/remove_node_code actions and wrappers#7680
Open
Remove obsolete SGX add_node_code/remove_node_code actions and wrappers#7680
add_node_code/remove_node_code actions and wrappers#7680Conversation
…d_sgx_measurement and remove_sgx_measurement Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove obsolete add_new_code and retire_code from CCF codebase
Remove obsolete add_new_code and retire_code methods
Feb 21, 2026
…nd Python wrappers Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot
AI
changed the title
Remove obsolete add_new_code and retire_code methods
Remove obsolete SGX Feb 21, 2026
add_node_code/remove_node_code actions and wrappers
maxtropets
reviewed
Feb 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes obsolete SGX-specific code for managing node code identifiers, as SGX is no longer a supported platform in CCF. The changes clean up dead code from constitution actions and Python test infrastructure.
Changes:
- Removed SGX-specific constitution actions (
add_node_code,remove_node_code) from both default and minimal CCF constitutions - Removed Python helper methods (
add_new_code,retire_code) and SGX platform branches from test infrastructure - Updated documentation to reference active (non-SGX) proposal actions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/infra/consortium.py | Removed add_new_code() and retire_code() methods; removed "sgx" platform branches from add_measurement() and remove_measurement() |
| samples/minimal_ccf/app/actions.js | Removed add_node_code and remove_node_code constitution actions |
| samples/constitutions/default/actions.js | Removed add_node_code and remove_node_code constitution actions |
| doc/operations/code_upgrade.rst | Updated to reference remove_snp_host_data instead of obsolete remove_node_code |
maxtropets
approved these changes
Feb 21, 2026
achamayou
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SGX is no longer a supported platform. The
add_node_codeandremove_node_codeconstitution actions and their Python wrappers are dead code.add_node_codeandremove_node_codefromsamples/constitutions/default/actions.jsandsamples/minimal_ccf/app/actions.jsadd_sgx_measurement/remove_sgx_measurementmethods and"sgx"branches fromadd_measurement()/remove_measurement()intests/infra/consortium.pydoc/operations/code_upgrade.rstto reference the active proposal actions (remove_snp_measurement,remove_virtual_measurement,remove_snp_host_data)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.