chore: Enhance deployment guides and improve OneLake data source creation#132
Open
Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:devfrom
Open
chore: Enhance deployment guides and improve OneLake data source creation#132Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:devfrom
Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:devfrom
Conversation
… configuration feat: update bicepparam to read environment variables for fabric capacity and workspace scripts: persist lakehouse IDs in azd env for downstream hooks scripts: improve OneLake data source creation with azd outputs and env store fallback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Harmanpreet-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801 and
toherman-msft
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the configuration and deployment experience for Microsoft Fabric resources by clarifying BYO (Bring Your Own) workflows, standardizing environment variable usage, and enhancing automation scripts to better support both new and existing deployments. The documentation now provides clearer guidance for each deployment mode, and the infrastructure and automation scripts have been updated to consistently read from environment variables and persist resource identifiers for downstream use.
Documentation improvements:
docs/parameter_guide.mdanddocs/deploymentguide.mdto clearly explain the different Fabric deployment modes (create,byo,none), how to set them using environment variables, and detailed steps for reusing existing Fabric capacities and workspaces. This includes guidance on how to locate required resource identifiers and the precedence of environment variables over hardcoded values. [1] [2]Infrastructure configuration:
infra/main.bicepparamto readfabricCapacityResourceId,FABRIC_WORKSPACE_ID, andFABRIC_WORKSPACE_NAMEfrom environment variables, ensuring that BYO resource identifiers can be supplied at deploy time viaazd env set.Automation script enhancements:
create_lakehouses.ps1to persist created and existing lakehouse IDs into the environment usingazd env set, making them available for downstream scripts and reruns.04_create_onelake_datasource.ps1to robustly resolve workspace and lakehouse IDs by checking Bicep outputs, environment variables, and persisted values from previous automation steps, increasing reliability in both new and BYO scenarios.Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information