FEAT: Adding descriptions to Techniques#2167
Merged
rlundeen2 merged 3 commits intoJul 15, 2026
Merged
Conversation
Add an optional description field to AttackTechniqueFactory (decorative metadata, excluded from the behavioral identity hash) and populate a concise description for every technique in the core, extra, and airt catalogs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
rlundeen2
changed the title
behnam-o
approved these changes
Jul 14, 2026
behnam-o
approved these changes
Jul 14, 2026
jsong468
reviewed
Jul 14, 2026
…nique-descriptions # Conflicts: # pyrit/setup/initializers/techniques/core.py
jsong468
reviewed
Jul 14, 2026
jsong468
left a comment
jsong468
left a comment
Contributor
There was a problem hiding this comment.
do we want these shown in our attack_techniques notebook or is that too verbose?
jsong468
reviewed
Jul 14, 2026
jsong468
approved these changes
Jul 14, 2026
Address review nits on PR microsoft#2167: open every description with an active verb and use consistent 'Frames' wording for the role_play variants (was cast/staged/framed synonyms), and rewrite the crescendo entries from noun phrases to active verbs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
descriptionfield to attack technique factories, so each technique inpyrit/setupcarries a concise summary of what it does.description: str | None = NoneonAttackTechniqueFactory.__init__(and forwarded throughwith_simulated_conversation), exposed via adescriptionproperty._build_identifier— it's decorative metadata and must not change a technique's behavioral identity hash.core,extra, andairtcatalogs.Right now these are informational only (as the title says, currently
useless/ decorative); a follow-up could surface them in registry/CLI listings. But even just as informational, I was missing some of the description that we're losing as we're migrating attack classes to techniques. I think there needs to be a place where you can see what the technique is doing with english.