Skip to content

MAINT Consolidate memory operations#2207

Merged
behnam-o merged 3 commits into
microsoft:mainfrom
behnam-o:maint/consolidate-memory-operations
Jul 16, 2026
Merged

MAINT Consolidate memory operations#2207
behnam-o merged 3 commits into
microsoft:mainfrom
behnam-o:maint/consolidate-memory-operations

Conversation

@behnam-o

@behnam-o behnam-o commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move shared SQLAlchemy query, insert, update, embedding, and disposal behavior into MemoryInterface
  • remove duplicate implementations from SQLite and Azure SQL memory backends
  • retain get_session as an explicit backend contract

Behnam Ousat added 2 commits July 15, 2026 17:26

@romanlutz romanlutz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I've been wanting to do this forever!!!

…emory-operations

# Conflicts:
#	pyrit/memory/azure_sql_memory.py
#	pyrit/memory/sqlite_memory.py
@behnam-o behnam-o added this pull request to the merge queue Jul 16, 2026
Merged via the queue into microsoft:main with commit 0bf64b5 Jul 16, 2026
53 checks passed
@behnam-o behnam-o deleted the maint/consolidate-memory-operations branch July 16, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants