Fix off-by-one in format #5942
Open
Fix off-by-one in format #5942
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you add a test case that exercises this fix? |
The original loop stopped at _Last (condition _First != _Last; ++_First), so the upper bound of each lead-byte range from CPINFOEXW::LeadByte was never marked. The Windows lead-byte ranges are inclusive, so the final byte in each pair must be set.
Member
|
I am confused because the product code change affects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original loop stopped at _Last (condition _First != _Last; ++_First), so the upper bound of each lead-byte range from CPINFOEXW::LeadByte was never marked. The Windows lead-byte ranges are inclusive, so the final byte in each pair must be set.