Reject placeholder list names from list grammar matches - #2784
Open
datduyng wants to merge 1 commit into
Open
Conversation
- Treat determiner-only listName captures (the/my/list) as invalid via checked_wildcard validation so bare list phrases fall through to the LLM - Normalize list names; execute-time guards; unit coverage for edge names - Authored TODO in listSchema.agr + schema-tuning guide note #5
Collaborator
|
Looking at this I think a better approach is to just remove the grammar rule that's causing the problem. If I say: "create a ingedients list and a shopping list" and then "add cheese to both" that should work. The agent shouldn't know or care about any grammar or caching. In fact, it should work regardless of language. A user should be able to create a list called "my"... or, my could refer to a list of the useres name but that should get resolved in translation and not in the agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject determiner/placeholder listName captures (the/my/list) via checked_wildcard + execute guards so bare list phrases fall through to the LLM while named lists still match.