Skip to content

Run extension tagging on main - #64209

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:fix-vscode-typescript-tag-checkout
Sep 9, 2026
Merged

Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:fix-vscode-typescript-tag-checkout

Conversation

@jakebailey

Copy link
Copy Markdown
Member

This was wrong in #64139, due to GitHub security changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The validation still permits adding a privileged pull_request trigger.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Moves VS Code extension tagging to trusted pushes on main.

Changes:

  • Replaces pull_request_target with a filtered push trigger.
  • Updates checkout, concurrency, and workflow validation.
File summaries
File Description
Herebyfile.mjs Validates the tagging workflow trigger.
.github/workflows/tag-vscode-typescript.yml Tags extension releases after version bumps reach main.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Herebyfile.mjs Outdated
@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Sep 9, 2026
@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Sep 9, 2026
Merged via the queue into microsoft:main with commit f3b04fe Sep 9, 2026
26 checks passed
@jakebailey
Jake Bailey (jakebailey) deleted the fix-vscode-typescript-tag-checkout branch September 9, 2026 04:23
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants