Skip to content

Fix editable ComboBox text contrast in Desert high-contrast theme #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarinov-msft wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix editable ComboBox text contrast in Desert high-contrast theme #790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c85a656
Fix editable ComboBox text contrast in Desert high-contrast theme
amarinov-msft Jun 29, 2026
89279fc
Fix editable ComboBox selected-text contrast via selection highlight …
amarinov-msft Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Sample Applications/WPFGallery/Views/BasicInput/ComboBoxPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using System.Windows.Documents;
using System.Windows;
using System.Windows.Documents;
using System.Windows.Media;
using System.Windows.Navigation;
using System.Windows.Shapes;

Expand All @@ -19,5 +21,11 @@ public ComboBoxPage(ComboBoxPageViewModel viewModel)
DataContext = this;

InitializeComponent();

// Fluent's HC selection color is WindowColor, washing out editable text selected on focus; use the Highlight color instead.
if (SystemParameters.HighContrast)

@dipeshmsft dipeshmsft Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to do something similar to what we did in MainWindow.xaml.cs.

Although, this code would work when the app / page is initialized. However, if we are on the page and the theme changes to something else, it may end up in wrong visuals.

Apart from that this is exactly what I was talking about.

{
Resources["TextControlSelectionHighlightColor"] = new SolidColorBrush(SystemColors.HighlightColor);
}
}
}
Loading