snapshot memory to disk, new from snapshot - disk to memory#13
Open
backurs wants to merge 5 commits intomicrosoft:mainfrom
Open
snapshot memory to disk, new from snapshot - disk to memory#13backurs wants to merge 5 commits intomicrosoft:mainfrom
backurs wants to merge 5 commits intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current repo only allows to snapshot bftrees that are disk-based. If we want to snapshot a bftree that is memory-based, we get a segmentation fault.
This PR implements functionality to snapshot in-memory bftree to disk. It simply reads all records from the in-memory bftree, creates an on-disk empty bftree, where it writes all the records.
It also creates a complementary function that takes as an input a path to a snapshot-ed bftree, reads it to create a disk-based bftree, reads all entries from it, creates an empty in-memory bftree and writes all the entries to the in-memory bftree.
While working on this PR I encountered a compilation error in file src/tests/concurrent.rs - the compiler complained about uninitialized vector in these lines:
So I replaced these lines with
which I think is equivalent.